Skip to content

Check for Windows OS or JULIA_COPY_STACKS on jcall, improve testing #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 18, 2020

Conversation

mkitti
Copy link
Member

@mkitti mkitti commented Mar 8, 2020

Squashed commit of the following:

commit 8dbbcdc
Author: Mark Kittisopikul [email protected]
Date: Fri Mar 6 21:29:18 2020 -0600

Enable JULIA_COPY_STACKS=0 on mac

commit b9b89ee
Author: Mark Kittisopikul [email protected]
Date: Fri Mar 6 19:43:35 2020 -0600

Reduce testing

commit 21b0198
Author: Mark Kittisopikul [email protected]
Date: Fri Mar 6 17:58:42 2020 -0600

Configure forced async tests

commit c9c3051
Author: Mark Kittisopikul [email protected]
Date: Fri Mar 6 17:39:43 2020 -0600

Don't expect exception on Windows

commit 2df1c84
Author: Mark Kittisopikul [email protected]
Date: Fri Mar 6 17:29:35 2020 -0600

Create new environment test flags, check async fail on windows

commit 56abdf6
Author: Mark Kittisopikul [email protected]
Date: Mon Feb 24 03:35:43 2020 -0600

Include but allow to fail linux @async case with JULIA_COPY_STACKS=0

commit 0c0279c
Author: Mark Kittisopikul [email protected]
Date: Mon Feb 24 03:14:16 2020 -0600

Do not initialize using @async on Windows

commit dfc4aea
Author: Mark Kittisopikul [email protected]
Date: Mon Feb 24 03:05:19 2020 -0600

Test JavaCall under @async

commit 7ebf526
Author: Mark Kittisopikul [email protected]
Date: Mon Feb 24 02:26:55 2020 -0600

Streamline Travis configuration, include Windows

commit bc2431d
Author: Mark Kittisopikul [email protected]
Date: Mon Feb 24 01:39:05 2020 -0600

JULIA_COPY_STACKS should not be recommended or asserted on Windows

commit 59973a3
Author: Mark Kittisopikul [email protected]
Date: Tue Feb 18 11:23:49 2020 -0600

Assert root Task for jcall and jfield

Squashed commit of the following:

commit 8dbbcdc
Author: Mark Kittisopikul <[email protected]>
Date:   Fri Mar 6 21:29:18 2020 -0600

    Enable JULIA_COPY_STACKS=0 on mac

commit b9b89ee
Author: Mark Kittisopikul <[email protected]>
Date:   Fri Mar 6 19:43:35 2020 -0600

    Reduce testing

commit 21b0198
Author: Mark Kittisopikul <[email protected]>
Date:   Fri Mar 6 17:58:42 2020 -0600

    Configure forced async tests

commit c9c3051
Author: Mark Kittisopikul <[email protected]>
Date:   Fri Mar 6 17:39:43 2020 -0600

    Don't expect exception on Windows

commit 2df1c84
Author: Mark Kittisopikul <[email protected]>
Date:   Fri Mar 6 17:29:35 2020 -0600

    Create new environment test flags, check async fail on windows

commit 56abdf6
Author: Mark Kittisopikul <[email protected]>
Date:   Mon Feb 24 03:35:43 2020 -0600

    Include but allow to fail linux @async case with JULIA_COPY_STACKS=0

commit 0c0279c
Author: Mark Kittisopikul <[email protected]>
Date:   Mon Feb 24 03:14:16 2020 -0600

    Do not initialize using @async on Windows

commit dfc4aea
Author: Mark Kittisopikul <[email protected]>
Date:   Mon Feb 24 03:05:19 2020 -0600

    Test JavaCall under @async

commit 7ebf526
Author: Mark Kittisopikul <[email protected]>
Date:   Mon Feb 24 02:26:55 2020 -0600

    Streamline Travis configuration, include Windows

commit bc2431d
Author: Mark Kittisopikul <[email protected]>
Date:   Mon Feb 24 01:39:05 2020 -0600

    JULIA_COPY_STACKS should not be recommended or asserted on Windows

commit 59973a3
Author: Mark Kittisopikul <[email protected]>
Date:   Tue Feb 18 11:23:49 2020 -0600

    Assert root Task for jcall and jfield
@mkitti
Copy link
Member Author

mkitti commented Mar 8, 2020

JULIA_COPY_STACKS=1 does not seem to work well on Windows, so we should not recommend setting that environmental variable on that operating system.

@mkitti
Copy link
Member Author

mkitti commented Mar 17, 2020

Users are finding that JULIA_COPY_STACKS=1 does not work on Windows:
https://discourse.julialang.org/t/problem-in-running-julia-on-juno/35412/2

@aviks
Copy link
Collaborator

aviks commented Mar 17, 2020

Is there any change needed to the documentation based on this PR?

@mkitti
Copy link
Member Author

mkitti commented Mar 18, 2020

I added some documentation for using JavaCall on Windows.

@aviks aviks merged commit 0ecb17e into JuliaInterop:master Mar 18, 2020
aviks added a commit that referenced this pull request Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants