Skip to content

Distributed worker manager doesn't use socket connection to infer worker ip #85

Open
@Moelf

Description

@Moelf

https://github.com/JuliaLang/julia/blob/0d00660a38f4d4049e12a97399e4ef613bf0d7dc/stdlib/Distributed/src/managers.jl#L568

for some reason we don't use the fact that we can call Sockets.getpeername() here, instead we read the stdout of the worker process.

This is problemmatic mainly because:

  1. the worker nodes always report the first IPv4 interface's address no matter if that's actually the interface it used to contact main node:
    https://github.com/JuliaLang/julia/blob/0d00660a38f4d4049e12a97399e4ef613bf0d7dc/stdlib/Sockets/src/addrinfo.jl#L272-L276

  2. the worker node may be running inside container (or whatever reason has virtual interface before everything else)

my questions: can we add a specialization for read_worker_host_port when config.io :: Sockets.TCPSocket?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions