Skip to content

Highlight a bit more the posibility of relative paths #1215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 4, 2019
Merged

Highlight a bit more the posibility of relative paths #1215

merged 3 commits into from
Sep 4, 2019

Conversation

Datseris
Copy link
Contributor

@Datseris Datseris commented Jun 2, 2019

Closes #1214

@@ -123,6 +123,8 @@ from that local repo are pulled when packages are updated.
Note that changes to files in the local package repository will not immediately be reflected when loading that package.
The changes would have to be committed and the packages updated in order to pull in the changes.

In addition, the local path given could also be relative with respect to the `Manifest.toml` file.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's relative to pwd I think?

@@ -180,6 +182,17 @@ Note that if you add a dependency to a package that tracks a local path, the Man
out of sync with the actual dependency graph. This means that the package will not be able to load that dependency since it is not recorded
in the Manifest. To synchronize the Manifest, use the REPL command `resolve`.

Similarly with `add`, `dev` can be given a path relative to the `Manifest.toml` file. Notice that to use add a relative path
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above, I don't think this is true.

@Datseris
Copy link
Contributor Author

Datseris commented Jun 2, 2019

Ok @KristofferC then I don't understand whether the existing state really solves #1214 .

What I want:

To be able to use a package, which has a path relative to the Manifest.toml file, not relative to the current working directory. Since it is possible to activate a specific project while the working directory has no relation whatsoever to the Manifest of the activated project, I must be certain that the package loaded by the Manifest file is really defined with respect to the Manifest file.

What happens now:

You may add a package to your manifest, relative to the current working directory, which may have no relation to manifest whatsoever.

So the question is:

Does this achieve what I want? If it does then it is only a matter of documenting it properly by changing the wording of my PR.

@fredrikekre
Copy link
Member

The path that is stored is relative the project file.

@Datseris
Copy link
Contributor Author

Datseris commented Jun 2, 2019

Thanks, this clarifies everything. It is a bit unintuitive that when you add a package, the path you add is relative to pwd but when you load one the path is relative to the Project.toml. But still, I will try to be transparent about this in the PR.

@Datseris
Copy link
Contributor Author

Datseris commented Jun 2, 2019

I've corrected my PR. Please let me know if it is correct now :)

@Datseris
Copy link
Contributor Author

Hello @fredrikekre , will this be merged ?

@fredrikekre
Copy link
Member

Yes

@Datseris
Copy link
Contributor Author

Perfect, thanks! Once it is merged I'll link it to the documentation of DrWatson, because we already had a user with a related question (JuliaDynamics/DrWatson.jl#62)

@Datseris
Copy link
Contributor Author

bump @fredrikekre

@fredrikekre fredrikekre self-assigned this Aug 20, 2019
@00vareladavid
Copy link
Contributor

This looks good to merge

@00vareladavid
Copy link
Contributor

bors r+

bors bot added a commit that referenced this pull request Sep 4, 2019
1215: Highlight a bit more the posibility of relative paths r=00vareladavid a=Datseris

Closes #1214 

Co-authored-by: George Datseris <[email protected]>
@bors
Copy link
Contributor

bors bot commented Sep 4, 2019

@bors bors bot merged commit 520c7e2 into JuliaLang:master Sep 4, 2019
@Datseris Datseris deleted the patch-1 branch September 4, 2019 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support relative paths for dev in Manifest
4 participants