-
-
Notifications
You must be signed in to change notification settings - Fork 276
Highlight a bit more the posibility of relative paths #1215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
docs/src/managing-packages.md
Outdated
@@ -123,6 +123,8 @@ from that local repo are pulled when packages are updated. | |||
Note that changes to files in the local package repository will not immediately be reflected when loading that package. | |||
The changes would have to be committed and the packages updated in order to pull in the changes. | |||
|
|||
In addition, the local path given could also be relative with respect to the `Manifest.toml` file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's relative to pwd I think?
docs/src/managing-packages.md
Outdated
@@ -180,6 +182,17 @@ Note that if you add a dependency to a package that tracks a local path, the Man | |||
out of sync with the actual dependency graph. This means that the package will not be able to load that dependency since it is not recorded | |||
in the Manifest. To synchronize the Manifest, use the REPL command `resolve`. | |||
|
|||
Similarly with `add`, `dev` can be given a path relative to the `Manifest.toml` file. Notice that to use add a relative path |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above, I don't think this is true.
Ok @KristofferC then I don't understand whether the existing state really solves #1214 . What I want: To be able to use a package, which has a path relative to the What happens now: You may add a package to your manifest, relative to the current working directory, which may have no relation to manifest whatsoever. So the question is: Does this achieve what I want? If it does then it is only a matter of documenting it properly by changing the wording of my PR. |
The path that is stored is relative the project file. |
Thanks, this clarifies everything. It is a bit unintuitive that when you add a package, the path you add is relative to |
I've corrected my PR. Please let me know if it is correct now :) |
Hello @fredrikekre , will this be merged ? |
Yes |
Perfect, thanks! Once it is merged I'll link it to the documentation of DrWatson, because we already had a user with a related question (JuliaDynamics/DrWatson.jl#62) |
bump @fredrikekre |
This looks good to merge |
bors r+ |
1215: Highlight a bit more the posibility of relative paths r=00vareladavid a=Datseris Closes #1214 Co-authored-by: George Datseris <[email protected]>
Closes #1214