Skip to content

Add paragraph on abstract Function fields to performance tips #50421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 6, 2023

Conversation

gdalle
Copy link
Contributor

@gdalle gdalle commented Jul 5, 2023

The following pattern is very common among beginners:

struct MyStruct
    f::Function
end

This PR advises against it

https://discourse.julialang.org/t/how-to-enforce-function-signature-type-on-a-struct/101211/2

@gdalle gdalle changed the title Add paragraph on abstract Function fields Add paragraph on abstract Function fields to performance tips Jul 5, 2023
@vtjnash vtjnash added the docs This change adds or pertains to documentation label Jul 5, 2023
Copy link
Member

@vtjnash vtjnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (with suggested changes)

@vtjnash vtjnash added the merge me PR is reviewed. Merge when all tests are passing label Jul 5, 2023
@dkarrasch dkarrasch merged commit 5579566 into JuliaLang:master Jul 6, 2023
@dkarrasch dkarrasch removed the merge me PR is reviewed. Merge when all tests are passing label Jul 6, 2023
@gdalle gdalle deleted the patch-3 branch July 6, 2023 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs This change adds or pertains to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants