Skip to content

atexit: move hook before precompile output #51849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 15, 2023
Merged

atexit: move hook before precompile output #51849

merged 4 commits into from
Nov 15, 2023

Conversation

vtjnash
Copy link
Member

@vtjnash vtjnash commented Oct 24, 2023

To show how this is used, this updates the profile_printing_listener background job to use this mechanism.

JeffBezanson
JeffBezanson approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@JeffBezanson JeffBezanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the right thing to do. But noting that we should properly expose _wait and _trywait since there are clearly good use cases for them.

@vtjnash

This comment was marked as outdated.

Sign in to view
@vtjnash vtjnash force-pushed the jn/earlier-atexit-hook branch 2 times, most recently from 99b2d96 to 5a0a467 Compare October 25, 2023 21:07
@vtjnash vtjnash mentioned this pull request Oct 27, 2023
Closed
@vtjnash vtjnash force-pushed the jn/earlier-atexit-hook branch from 3bba632 to 5944c7a Compare October 31, 2023 17:14
@vtjnash vtjnash added the merge me PR is reviewed. Merge when all tests are passing label Oct 31, 2023
@vtjnash vtjnash force-pushed the jn/earlier-atexit-hook branch from 5944c7a to ec65b41 Compare November 1, 2023 16:57
@vtjnash vtjnash removed the merge me PR is reviewed. Merge when all tests are passing label Nov 2, 2023
@vtjnash vtjnash force-pushed the jn/earlier-atexit-hook branch from ec65b41 to b5ca46c Compare November 8, 2023 15:13
@vtjnash vtjnash added merge me PR is reviewed. Merge when all tests are passing and removed merge me PR is reviewed. Merge when all tests are passing labels Nov 8, 2023
@vtjnash
test: fix race in atexit test
4fd9692 
Exposed by the presence of any atexit hooks in the new process, such as added in this PR.
@vtjnash
atexit: move hook before precompile output
b638381 
To show how this is used, this updates the profile_printing_listener
background job to use this mechanism.

Also ensure mktemp and mktempdir cleanup even on unexpected exit:
Previously this was relying on all Tasks running to completion, which is
not a good assumption. Add the atexit hook, so that even if they do not
run to completion, they still get cleaned up.
@vtjnash
restore deprecated function for Pkg tests
67ec832
@vtjnash
improve "deadlock avoidance" of unexpectedly abrubt exits
d8a410c
@vtjnash vtjnash force-pushed the jn/earlier-atexit-hook branch from b5ca46c to d8a410c Compare November 14, 2023 21:09
@vtjnash vtjnash added merge me PR is reviewed. Merge when all tests are passing don't squash Don't squash merge labels Nov 14, 2023
@vtjnash vtjnash merged commit 539ca89 into master Nov 15, 2023
@vtjnash vtjnash deleted the jn/earlier-atexit-hook branch November 15, 2023 01:34
@giordano giordano removed the merge me PR is reviewed. Merge when all tests are passing label Nov 15, 2023
@johnnychen94
Copy link
Member

johnnychen94 commented Nov 16, 2023 •
edited
Loading

Just asking, will this be backported to 1.10?

@KristofferC KristofferC mentioned this pull request Feb 15, 2024
Closed
@IanButterworth IanButterworth mentioned this pull request Aug 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeffBezanson JeffBezanson JeffBezanson approved these changes

Assignees
No one assigned
Labels
don't squash Don't squash merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vtjnash @johnnychen94 @JeffBezanson @giordano