@assume_effects :foldable for all the ccalls #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 85.51% // Head: 75.36% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #56 +/- ##
===========================================
- Coverage 85.51% 75.36% -10.15%
===========================================
Files 3 3
Lines 359 341 -18
===========================================
- Hits 307 257 -50
- Misses 52 84 +32
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
This currently requires bumping the Julia compatibility to v1.6. (There is no applicable Compat.jl entry available for earlier versions; is a backport envisioned?) Otherwise LGTM. The failure in macOS-latest is an unrelated issue (#57). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will let the compiler constant fold all of these ccalls on Julia 1.8 and up.