Loosen types with ldiv! and dot of InverseDiagonal #878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All that was required to make [this example](https://discourse.julialang.org/t/nonlinear-optimization-help-optim-jump-something-else/47163/2) work was to patch in a method for `ldiv!`. Loosening this type restriction should let even more array types work here. I've tested this and it doesn't look like it introduces any method ambiguities.
Codecov Report
@@ Coverage Diff @@
## master #878 +/- ##
==========================================
- Coverage 82.07% 82.03% -0.04%
==========================================
Files 43 43
Lines 2778 2778
==========================================
- Hits 2280 2279 -1
- Misses 498 499 +1
Continue to review full report at Codecov.
|
|
Thanks, though I fixed this while also not doing type piracy in a recent PR :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All that was required to make this example work was to patch in a method for
ldiv!. Loosening this type restriction should let even more array types work here. I've tested this and it doesn't look like it introduces any method ambiguities.