Now deepcopy(::AbstractModel) calls error #2079
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t copying the underlying solver and, if this is not done, then deepcopy does not behave as would be expected).
mlubin
reviewed
Oct 11, 2019
…or Model, not AbstractModel. Added more info to the error message.
Codecov Report
@@ Coverage Diff @@
## master #2079 +/- ##
==========================================
- Coverage 91.1% 91.08% -0.03%
==========================================
Files 38 38
Lines 4318 4319 +1
==========================================
Hits 3934 3934
- Misses 384 385 +1
Continue to review full report at Codecov.
|
blegat
reviewed
Oct 11, 2019
blegat
reviewed
Oct 13, 2019
blegat
approved these changes
Oct 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no plan to support copying the underlying solver and, if this is not done, then the object returned by deepcopy does not behave as would be expected (both copy and original edit the same underlying model).
This has been a source of frustration before:
https://discourse.julialang.org/t/jump-gurobi-bug-value-of-variable-in-solved-model-changes-after-deleting-another-variable/29619/7
https://discourse.julialang.org/t/strange-behavior-with-deepcopy/23342/3
https://discourse.julialang.org/t/workaround-for-modifying-coefficients-in-constraints-in-jump/27123/9