Skip to content

fix over-parameterization of DQExperience #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 30, 2021
Merged

Conversation

zsunberg
Copy link
Member

@zsunberg
Copy link
Member Author

@MaximeBouton , I believe this fixes the bug in the link above. Ideally we would have a test that exercises this bug and the fix, but I don't have time to create it right now.

I have one question for you. This allows people to use Float64, which could cause performance degradation. My view is that having something that works is more important, but just wanted to see if you have a comment.

@zsunberg zsunberg merged commit e547dcf into master Sep 30, 2021
@zsunberg zsunberg deleted the zsunberg-patch-1 branch September 30, 2021 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant