Skip to content

Generalize findnz and reduction to AbstractSparseVectors #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 12, 2022

Conversation

dkarrasch
Copy link
Member

Closes #10 and closes #16.

@codecov-commenter
Copy link

codecov-commenter commented Jul 7, 2022

Codecov Report

Merging #175 (1b75678) into main (e081db6) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #175      +/-   ##
==========================================
+ Coverage   91.66%   91.69%   +0.02%     
==========================================
  Files          11       11              
  Lines        7102     7102              
==========================================
+ Hits         6510     6512       +2     
+ Misses        592      590       -2     
Impacted Files Coverage Δ
src/sparsevector.jl 94.17% <100.00%> (ø)
src/linalg.jl 84.58% <0.00%> (+0.17%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@ViralBShah ViralBShah merged commit ac1f016 into main Jul 12, 2022
@ViralBShah ViralBShah deleted the dk/abstract branch July 12, 2022 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request for additional findnz() method efficient method for sum(::SparseColumnView) is missing
3 participants