Fix EmpiricalUnivariateDistribution #662
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Remember to check for open PRs, see #661 |
|
Oh, didn't see that, I told you in Discourse that I would submit a PR, that is why I didn't even check. I like that you are using quantile(d.values, p) instead of reimplementing the bisection, I will close this one. |
No worries. I started on this yesterday right after I realized how broken the existing version was. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix the
quantileandrandofEmpiricalUnivariateDistribution. I have also changed the distribution to be discrete instead of continuous because it relies on theecdffromStatsBase.jl, which doesn't perform interpolation.Could you please review the changes and see if I got all the corner cases right? I am bisecting the CDF values in order to find the quantile, I think this is the best we can do?