implemented Data.streamfrom
for Data.field
#45
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ok, this still has a couple of issues (in particular, I haven't yet figured out how to properly deserialize the
Bool
s), but it is a good start. This allows you to pull individual fields without loading the whole file (at least I know it does that in the case where memory mapping is used, not quite sure what happens otherwise)."But ExpandingMan, clearly the right thing to do is to implement the ability to pull arbitrarily small subsets of rows from columns, and the
Data.Field
implementation should be based on that."Well, yes, true, but unfortunately the
DataStreams
interface standard doesn't support that yet (I think), though it should definitely be expanded to. As is, there is a hell of a lot of extra overhead in pulling individual fields. It'll be pretty simple to implement pulling subsets of columns once it is added to the standard. TheData.Field
stuff I wrote will still be useful (and on a personal note, it helped me to learn more about how these types of formats work).Ok, if you guys can let me know how this can be improved, I'd be happy to make some changes so that this can be merged. At the moment, I think that the only problem is with the
Bool
s. Thanks!