-
Notifications
You must be signed in to change notification settings - Fork 123
WIP: Supporting functions for array symbolics #123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some preliminary thoughts
JuliaParallel/DistributedArrays.jl#4 is a good list of operations to wrap. |
Codecov Report
@@ Coverage Diff @@
## master #123 +/- ##
==========================================
- Coverage 86.10% 84.30% -1.81%
==========================================
Files 12 13 +1
Lines 993 1153 +160
==========================================
+ Hits 855 972 +117
- Misses 138 181 +43
Continue to review full report at Codecov.
|
This reverts commit da16055.
Codecov Report
@@ Coverage Diff @@
## master #123 +/- ##
==========================================
- Coverage 85.31% 83.94% -1.37%
==========================================
Files 12 12
Lines 1171 1202 +31
==========================================
+ Hits 999 1009 +10
- Misses 172 193 +21
Continue to review full report at Codecov.
|
cc @YingboMa check out all the smilarterm changes lol, we should make that the default maybe?? But you were the one who switched it back to using |
builds on #215