Skip to content

WIP: Supporting functions for array symbolics #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
May 28, 2021
Merged

WIP: Supporting functions for array symbolics #123

merged 17 commits into from
May 28, 2021

Conversation

shashi
Copy link
Member

@shashi shashi commented Aug 16, 2020

builds on #215

Copy link
Member

@MasonProtter MasonProtter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some preliminary thoughts

@shashi
Copy link
Member Author

shashi commented Feb 28, 2021

JuliaParallel/DistributedArrays.jl#4 is a good list of operations to wrap.

@codecov-io
Copy link

codecov-io commented Feb 28, 2021

Codecov Report

Merging #123 (c5527fe) into master (e84bff9) will decrease coverage by 1.80%.
The diff coverage is 45.07%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #123      +/-   ##
==========================================
- Coverage   86.10%   84.30%   -1.81%     
==========================================
  Files          12       13       +1     
  Lines         993     1153     +160     
==========================================
+ Hits          855      972     +117     
- Misses        138      181      +43     
Impacted Files Coverage Δ
src/SymbolicUtils.jl 100.00% <ø> (ø)
src/arrays.jl 36.06% <36.06%> (ø)
src/types.jl 91.01% <100.00%> (+1.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e84bff9...c5527fe. Read the comment docs.

@shashi shashi changed the title WIP: Array symbolics WIP: Supporting functions for array symbolics Apr 16, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #123 (e982660) into master (cde48fa) will decrease coverage by 1.36%.
The diff coverage is 43.58%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #123      +/-   ##
==========================================
- Coverage   85.31%   83.94%   -1.37%     
==========================================
  Files          12       12              
  Lines        1171     1202      +31     
==========================================
+ Hits          999     1009      +10     
- Misses        172      193      +21     
Impacted Files Coverage Δ
src/methods.jl 79.06% <0.00%> (-5.94%) ⬇️
src/types.jl 84.77% <34.61%> (-3.09%) ⬇️
src/rule.jl 85.84% <50.00%> (-0.65%) ⬇️
src/abstractalgebra.jl 100.00% <100.00%> (+1.35%) ⬆️
src/api.jl 91.42% <100.00%> (ø)
src/ordering.jl 92.64% <100.00%> (+0.10%) ⬆️
src/code.jl 81.00% <0.00%> (-0.71%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cde48fa...e982660. Read the comment docs.

@shashi
Copy link
Member Author

shashi commented May 28, 2021

cc @YingboMa check out all the smilarterm changes lol, we should make that the default maybe?? But you were the one who switched it back to using promote_symtype.

@shashi shashi merged commit 3d78a70 into master May 28, 2021
@shashi shashi deleted the s/array-impl branch May 28, 2021 19:44
@shashi shashi restored the s/array-impl branch June 7, 2021 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants