update: SciMLBase modified ReturnCode #162
Conversation
- DifferentialEquations 7.6.0 introduced a non-backwards compatible change with [#867](SciML/DifferentialEquations.jl#867). Modia was corrected to cope with this change (based on [#162](#162)). - Newest DifferentialEquations does not longer support Measurements. Deactivated temporarily tests with measurements.
|
Thanks for the pull request. I have just introduced the proposed changes in main together with related changes (and deactivating temporarily tests with Measurements, since not support in DifferentialEquations 7.7.0) |
| @@ -258,7 +258,7 @@ function simulate!(m::SimulationModel{FloatType,TimeType}, algorithm=missing; me | |||
| eh.nFullRestartEvents, m.linearEquations) | |||
|
|
|||
| # Raise an error, if simulation was not successful | |||
| if !(solution.retcode == :Default || solution.retcode == :Success || solution.retcode == :Terminated) | |||
| if !(solution.retcode in [ReturnCode.Default, ReturnCode.Success, ReturnCode.Terminated]) | |||
There was a problem hiding this comment.
Instead of this you should use SciMLBase.successful_retcode(solution.retcode). See https://docs.sciml.ai/SciMLBase/stable/interfaces/Solutions/#retcodes
There was a problem hiding this comment.
Currently, SciMLBase is not a package that is imported in Modia. Is there a way to access SciMLBase via DifferentialEquations, or is it necessary that this package is explicitly imported?
There was a problem hiding this comment.
It's always re-exported by DifferentialEquations.jl
There was a problem hiding this comment.
Thanks. Fixed this as you suggested.
ReturnCode was changed in SciMLBase SciML/SciMLBase.jl@fba56c9