Skip to content

rustc: disable tests for aarch64 #39000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2018
Merged

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Apr 16, 2018

upstream is doing the same

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

upstream is doing the same
@Mic92 Mic92 requested a review from LnL7 as a code owner April 16, 2018 11:28
@GrahamcOfBorg GrahamcOfBorg added 6.topic: rust General-purpose programming language emphasizing performance, type safety, and concurrency. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Apr 16, 2018
@vcunat vcunat added the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 16, 2018
@vcunat
Copy link
Member

vcunat commented Apr 16, 2018

I'd like the same for staging-18.03, as all of the last several build attempts failed in there (blocking nontrivial number of packages).

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: rustc

Partial log (click to expand)

   Compiling parking_lot_core v0.2.9
   Compiling parking_lot v0.5.3
   Compiling flate2 v1.0.1
   Compiling rustc_data_structures v0.0.0 (file:///private/tmp/nix-build-rustc-1.25.0.drv-0/rustc-1.25.0-src/src/librustc_data_structures)
   Compiling rls-span v0.4.0
   Compiling rls-data v0.15.0
   Compiling syntax_pos v0.0.0 (file:///private/tmp/nix-build-rustc-1.25.0.drv-0/rustc-1.25.0-src/src/libsyntax_pos)
   Compiling rustc_errors v0.0.0 (file:///private/tmp/nix-build-rustc-1.25.0.drv-0/rustc-1.25.0-src/src/librustc_errors)
building of '/nix/store/0xbchrdwp5is09d5pbg1pnx9j1hwlqfb-rustc-1.25.0.drv' timed out after 1800 seconds
�[31;1merror:�[0m build of '/nix/store/0xbchrdwp5is09d5pbg1pnx9j1hwlqfb-rustc-1.25.0.drv' failed

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: rustc

Partial log (click to expand)

   Compiling syntax_pos v0.0.0 (file:///build/rustc-1.25.0-src/src/libsyntax_pos)
   Compiling rls-span v0.4.0
   Compiling rls-data v0.15.0
   Compiling rustc_errors v0.0.0 (file:///build/rustc-1.25.0-src/src/librustc_errors)
   Compiling backtrace v0.3.5
   Compiling rustc_const_math v0.0.0 (file:///build/rustc-1.25.0-src/src/librustc_const_math)
   Compiling proc_macro v0.0.0 (file:///build/rustc-1.25.0-src/src/libproc_macro)
   Compiling syntax_ext v0.0.0 (file:///build/rustc-1.25.0-src/src/libsyntax_ext)
building of '/nix/store/87v62806vy0ahlhfqn6ypn8iq1h65qzl-rustc-1.25.0.drv' timed out after 3600 seconds
�[31;1merror:�[0m build of '/nix/store/87v62806vy0ahlhfqn6ypn8iq1h65qzl-rustc-1.25.0.drv' failed

@Mic92 Mic92 merged commit 74ed06e into NixOS:master Apr 16, 2018
@Mic92 Mic92 deleted the rustc-disable-aarch64-tests branch April 16, 2018 13:14
@Mic92
Copy link
Member Author

Mic92 commented Apr 16, 2018

I will make a pull request for staging-18.03 later, if I don't forget it.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: rustc

Partial log (click to expand)

these paths will be fetched (89.08 MiB download, 275.79 MiB unpacked):
  /nix/store/s92vr5q33vry5caipwi2lsqz6zdf9g7c-rustc-1.25.0
copying path '/nix/store/s92vr5q33vry5caipwi2lsqz6zdf9g7c-rustc-1.25.0' from 'https://cache.nixos.org'...
/nix/store/s92vr5q33vry5caipwi2lsqz6zdf9g7c-rustc-1.25.0

vcunat pushed a commit that referenced this pull request Apr 17, 2018
@vcunat
Copy link
Member

vcunat commented Apr 17, 2018

Picked as b694e7b.

@samueldr samueldr removed the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: rust General-purpose programming language emphasizing performance, type safety, and concurrency. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants