Improve hashtable completion

[MartinGC94]

PR Summary

Fixes a few things about hashtable completion:

1. Use partial input to filter the suggested keys
2. Filters out keys that have already been specified in the hashtable
3. Allows hashtable key completion to happen on blank lines, even if a key/value pair was specified on an earlier line

Example of a scenario that currently fails, but will get fixed by this PR:

ls | sort @{
Expression={}
<Cursor here>
}

Also adds completers for the Arguments parameter for Invoke-CimMethod the FilterHashtable parameter for Get-WinEvent the Property Parameter for the cim cmdlets and the standard cim completers for Set-CimInstance.
This also removes duplicates from member completion in scenarios like ls | select Attributes,<Cursor here> this could be split off into its own PR but since it depends on changes made in this PR I thought I may as well include it here.
Finally it adds some basic completion support for hashtables used for splatting. The pseudo binding doesn't take the hashtable parameters into account so it's not perfect but IMO some completion is better than none.

Fixes #9239

PR Checklist

• PR has a meaningful title
  • Use the present tense and imperative mood when describing your changes
• Summarized changes
• Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
• This PR is ready to merge and is not Work in Progress.
  • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
• Breaking changes
  • None
  • OR
  • Experimental feature(s) needed
    • Experimental feature name(s):
• User-facing changes
  • Not Applicable
  • OR
  • Documentation needed
    • Issue filed:
• Testing - New and feature
  • N/A or can only be tested interactively
  • OR
  • Make sure you've added a new test if existing tests do not effectively test the code changed
• Tooling
  • I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
  • OR
  • I have considered the user experience from a tooling perspective and opened an issue in the relevant tool repository. This may include:
    • Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode
      (which runs in a different PS Host).
      • Issue filed:
    • Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
      • Issue filed:
    • Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
      • Issue filed:
    • Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).
      • Issue filed:

[iSazonov]

I like this

[ghost]

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

[iSazonov]

LGTM with one minor comment.

[adityapatwardhan]

@daxian-dbw can you have a look?

[ghost]

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

[MartinGC94]

I understand if you are busy, to help prioritize I will say that out of all my open PRs, this is the one I'm most interested in seeing in the near future. It's just so convenient being able to tab complete parameters in splatting hashtables.

[daxian-dbw]

@MartinGC94 Sorry for the long delay on this. I will get to this PR this week.

[ghost]

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

[daxian-dbw]

Sorry for the delay on review.
The changes overall look good. Thanks for the improvements!

[daxian-dbw]

LGTM

[pull-request-quantifier-deprecated]

This PR has 285 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

---

Quantification details

Label      : Large
Size       : +234 -51
Percentile : 68.5%

Total files changed: 4

Change summary by file extension:
.cs : +178 -48
.ps1 : +56 -3

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

• Fast and predictable releases to production:
  • Optimal size changes are more likely to be reviewed faster with fewer
    iterations.
  • Similarity in low PR complexity drives similar review times.
• Review quality is likely higher as complexity is lower:
  • Bugs are more likely to be detected.
  • Code inconsistencies are more likely to be detetcted.
• Knowledge sharing is improved within the participants:
  • Small portions can be assimilated better.
• Better engineering practices are exercised:
  • Solving big problems by dividing them in well contained, smaller problems.
  • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

• Use the PullRequestQuantifier to quantify your PR accurately
  • Create a context profile for your repo using the context generator
  • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
  • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
  • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
• Change your engineering behaviors
  • For PRs that fall outside of the desired spectrum, review the details and check if:
    • Your PR could be split in smaller, self-contained PRs instead
    • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

• One line was added: +1 -0
• One line was deleted: +0 -1
• One line was modified: +1 -1 (git diff doesn't know about modified, it will
  interpret that line like one addition plus one deletion)
• Change percentiles: Change characteristics (addition, deletion, modification)
  of this PR in relation to all other PRs within the repository.

---

Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

[daxian-dbw]

The Invoke-RestMethod test failures are known issue, not related to changes in this PR.

[ghost]

🎉v7.3.0-preview.3 has been released which incorporates this pull request.:tada:

Handy links:

• Release Notes

[santisq]

Sorry if this is not the right place to comment but I've just noticed this a few days ago and I must say it's amazing. Thank you for the hard work! 💪

[SeeminglyScience]

@MartinGC94 don't know if you have a presence in twitter or reddit, but in case you don't lurk here's some more folks very excited to hear about this finally coming 😁

https://twitter.com/SeeminglyScienc/status/1595149054610399232

https://old.reddit.com/r/PowerShell/comments/z2qxed/powershell_ide_that_supports_tab/ixi3yu8/?context=10000

Twitter

reddit

PowerShell IDE That Supports Tab Completion/Intellisense for PowerShell Classes

It's worth noting that this PR is one of *many* of Martin's absolutely incredible PRs. A good chunk of which made it into v7.3.0 GA including...

[MartinGC94]

Thanks for the kind words :)
It's always nice to hear people appreciate one's work. ❤