Skip to content

Add find.exe to legacy native command arg passing behavior for Windows #17715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 20, 2022

Conversation

JamesWTruher
Copy link
Collaborator

@JamesWTruher JamesWTruher commented Jul 19, 2022

Addresses #15261.
Add tests.

PR Summary

In response to Issue #15261 and is a part of the NativeCommandArgumentPassing experimental feature.
The feature doesn't actually break --% as the argument list is created correctly when --% is present. However,
find.exe has some very specific behavior which is problematic when using the ArgumentList code path.

#15261 has more details.

PR Context

PR Checklist

@ghost ghost assigned anmenaga Jul 19, 2022
Copy link
Member

@daxian-dbw daxian-dbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daxian-dbw daxian-dbw assigned daxian-dbw and unassigned anmenaga Jul 20, 2022
@daxian-dbw daxian-dbw added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Jul 20, 2022
@daxian-dbw daxian-dbw merged commit 031fa93 into PowerShell:master Jul 20, 2022
@ghost
Copy link

ghost commented Aug 12, 2022

🎉v7.3.0-preview.7 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants