Skip to content

[release/v7.4] Move .NET method invocation logging to after the needed type conversion is done for method arguments #25568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

pwshBot
Copy link
Collaborator

@pwshBot pwshBot commented May 14, 2025

Backport of #25022 to release/v7.4

Triggered by @TravisEz13 on behalf of @daxian-dbw

Original CL Label: CL-Engine

/cc @PowerShell/powershell-maintainers

Impact

Choose either tooling or Customer impact.

Tooling Impact

  • Required tooling change
  • Optional tooling change (include reasoning)

Customer Impact

  • Customer reported
  • Found internally

[Select one or both of the boxes. Describe how this issue impacts customers, citing the expected and actual behaviors and scope of the issue. If customer-reported, provide the issue number.]

Regression

  • Yes
  • No

[If yes, specify when the regression was introduced. Provide the PR or commit if known.]

Testing

[How was the fix verified? How was the issue missed previously? What tests were added?]

Risk

  • High
  • Medium
  • Low

[High/Medium/Low. Justify the indication by mentioning how risks were measured and addressed.]

@microsoft-github-policy-service microsoft-github-policy-service bot added the Review - Needed The PR is being reviewed label May 22, 2025
@TravisEz13 TravisEz13 added CL-Engine Indicates that a PR should be marked as an engine change in the Change Log BackPort-7.4.x-Approved and removed Review - Needed The PR is being reviewed labels Jun 3, 2025
@daxian-dbw daxian-dbw changed the title [release/v7.4]!!!MERGE_CONFLICT!!! Move .NET method invocation logging to after the needed type conversion is done for method arguments [release/v7.4] Move .NET method invocation logging to after the needed type conversion is done for method arguments Jun 3, 2025
@daxian-dbw
Copy link
Member

@TravisEz13 Please review my changes. Reference: #25357

@TravisEz13
Copy link
Member

/azp run PowerShell-CI-linux-packaging, PowerShell-Windows-Packaging-CI

Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@TravisEz13 TravisEz13 merged commit 133f616 into PowerShell:release/v7.4 Jun 4, 2025
34 checks passed
Copy link
Contributor

microsoft-github-policy-service bot commented Jun 4, 2025

📣 Hey @@pwshBot, how did we do? We would love to hear your feedback with the link below! 🗣️

🔗 https://aka.ms/PSRepoFeedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BackPort-7.4.x-Approved CL-Engine Indicates that a PR should be marked as an engine change in the Change Log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants