Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: ProtonMail/go-crypto
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.1.2
Choose a base ref
...
head repository: ProtonMail/go-crypto
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.1.3
Choose a head ref
  • 10 commits
  • 20 files changed
  • 2 contributors

Commits on Nov 11, 2024

  1. Add argon2 test vector for 32-bit platforms (#245)

    32-bit platforms fail to allocate the 2 GiB of RAM that argon2 requires in the RFC9580 test vector.
    Thus, this PR skips the test for 32-bit platforms and adds a separate test vector with smaller parameters.
    lubux authored Nov 11, 2024
    Configuration menu
    Copy the full SHA
    c0ca2b8 View commit details
    Browse the repository at this point in the history
  2. Validate argon2 params on read (#246)

    Argon2 s2k parameters were previously not validated on the OpenPGP side before invoking Argon2, which could lead to potential panics during runtime. This commit introduces a validation step for these parameters before calling Argon2, ensuring that invalid inputs are caught early and an appropriate error is returned instead of risking a panic.
    
    Co-authored-by: Daniel Huigens <[email protected]>
    lubux and twiss authored Nov 11, 2024
    Configuration menu
    Copy the full SHA
    d7733dc View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    63e3da1 View commit details
    Browse the repository at this point in the history
  4. Add SerializeSymmetricKeyEncryptedAEADReuseKey

    Allow explicitly indicating whether AEAD is supported when creating
    an SKESK packet, instead of looking at config.AEAD().
    
    The config is no longer reliable, and we shouldn't mix SKESKv3 and
    SEIPDv2, for example.
    twiss committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    ee67844 View commit details
    Browse the repository at this point in the history
  5. Deprecate SerializeEncryptedKey[WithHiddenOption] and SerializeSymmet…

    …ricKeyEncryptedReuseKey
    
    These functions don't allow explicitly indicating whether AEAD is
    supported and are thus prone to misuse. The *AEAD versions should
    be used instead.
    twiss committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    1efe4a0 View commit details
    Browse the repository at this point in the history
  6. Improve documentation

    Document that the `aeadSupported` parameter passed to
    `SerializeEncryptedKeyAEAD[withHiddenOption]`,
    `SerializeSymmetricKeyEncryptedAEADReuseKey`, and
    `SerializeSymmetricallyEncrypted` must match.
    twiss committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    531d9f5 View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2024

  1. Adapt aead preferences on key generation (#248)

    Advertise SEIPDv2 and AEAD modes during key generation only if AEAD configuration is enabled.
    lubux authored Nov 12, 2024
    Configuration menu
    Copy the full SHA
    9ad5572 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #247 from ProtonMail/improve-aead

    Improve AEAD handling
    twiss authored Nov 12, 2024
    Configuration menu
    Copy the full SHA
    33a08b3 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2024

  1. Improve error message for decryption with a session key (#237)

    * feat: Improve error message for decryption with a session key
    
    * chore: Add explicit error message strings to tests
    
    * feat: Update SEIPD test vectors
    
    * chore: Move expected error to the old position
    
    * feat: Unify mdc integrity error
    
    * feat: Add aead test for missing last auth tag
    
    * docs: Add comments when handling parsing errors
    
    * feat: Unify parsing errors in SEIPDv1 decryption
    lubux authored Nov 18, 2024
    Configuration menu
    Copy the full SHA
    5e3e39d View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2024

  1. Flag to allow signing key decryption (#251)

    Adds a flag InsecureAllowDecryptionWithSigningKeys that allows to use keys for decryption 
    that are marked as signing keys only.
    lubux authored Nov 25, 2024
    Configuration menu
    Copy the full SHA
    5521d83 View commit details
    Browse the repository at this point in the history
Loading