-
Notifications
You must be signed in to change notification settings - Fork 110
Comparing changes
Open a pull request
base repository: ProtonMail/go-crypto
base: v1.1.2
head repository: ProtonMail/go-crypto
compare: v1.1.3
- 10 commits
- 20 files changed
- 2 contributors
Commits on Nov 11, 2024
-
Add argon2 test vector for 32-bit platforms (#245)
32-bit platforms fail to allocate the 2 GiB of RAM that argon2 requires in the RFC9580 test vector. Thus, this PR skips the test for 32-bit platforms and adds a separate test vector with smaller parameters.
Configuration menu - View commit details
-
Copy full SHA for c0ca2b8 - Browse repository at this point
Copy the full SHA c0ca2b8View commit details -
Validate argon2 params on read (#246)
Argon2 s2k parameters were previously not validated on the OpenPGP side before invoking Argon2, which could lead to potential panics during runtime. This commit introduces a validation step for these parameters before calling Argon2, ensuring that invalid inputs are caught early and an appropriate error is returned instead of risking a panic. Co-authored-by: Daniel Huigens <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for d7733dc - Browse repository at this point
Copy the full SHA d7733dcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 63e3da1 - Browse repository at this point
Copy the full SHA 63e3da1View commit details -
Add SerializeSymmetricKeyEncryptedAEADReuseKey
Allow explicitly indicating whether AEAD is supported when creating an SKESK packet, instead of looking at config.AEAD(). The config is no longer reliable, and we shouldn't mix SKESKv3 and SEIPDv2, for example.
Configuration menu - View commit details
-
Copy full SHA for ee67844 - Browse repository at this point
Copy the full SHA ee67844View commit details -
Deprecate SerializeEncryptedKey[WithHiddenOption] and SerializeSymmet…
…ricKeyEncryptedReuseKey These functions don't allow explicitly indicating whether AEAD is supported and are thus prone to misuse. The *AEAD versions should be used instead.
Configuration menu - View commit details
-
Copy full SHA for 1efe4a0 - Browse repository at this point
Copy the full SHA 1efe4a0View commit details -
Document that the `aeadSupported` parameter passed to `SerializeEncryptedKeyAEAD[withHiddenOption]`, `SerializeSymmetricKeyEncryptedAEADReuseKey`, and `SerializeSymmetricallyEncrypted` must match.
Configuration menu - View commit details
-
Copy full SHA for 531d9f5 - Browse repository at this point
Copy the full SHA 531d9f5View commit details
Commits on Nov 12, 2024
-
Adapt aead preferences on key generation (#248)
Advertise SEIPDv2 and AEAD modes during key generation only if AEAD configuration is enabled.
Configuration menu - View commit details
-
Copy full SHA for 9ad5572 - Browse repository at this point
Copy the full SHA 9ad5572View commit details -
Merge pull request #247 from ProtonMail/improve-aead
Improve AEAD handling
Configuration menu - View commit details
-
Copy full SHA for 33a08b3 - Browse repository at this point
Copy the full SHA 33a08b3View commit details
Commits on Nov 18, 2024
-
Improve error message for decryption with a session key (#237)
* feat: Improve error message for decryption with a session key * chore: Add explicit error message strings to tests * feat: Update SEIPD test vectors * chore: Move expected error to the old position * feat: Unify mdc integrity error * feat: Add aead test for missing last auth tag * docs: Add comments when handling parsing errors * feat: Unify parsing errors in SEIPDv1 decryption
Configuration menu - View commit details
-
Copy full SHA for 5e3e39d - Browse repository at this point
Copy the full SHA 5e3e39dView commit details
Commits on Nov 25, 2024
-
Flag to allow signing key decryption (#251)
Adds a flag InsecureAllowDecryptionWithSigningKeys that allows to use keys for decryption that are marked as signing keys only.
Configuration menu - View commit details
-
Copy full SHA for 5521d83 - Browse repository at this point
Copy the full SHA 5521d83View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v1.1.2...v1.1.3