Skip to content

Don't wrongly discard text immediately before an admonition #1092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 30, 2020

Conversation

oprypin
Copy link
Contributor

@oprypin oprypin commented Dec 30, 2020

foo
**foo**
!!! note "Admonition"

In the previous state, the "foo" text would be completely obliterated, but now it will be kept, and the admonition will be rendered as well.

@oprypin
Copy link
Contributor Author

oprypin commented Dec 30, 2020

This is a bug, but it's not obvious what behavior is the correct one.
This PR is the more pragmatic one, and #1093 is an alternative.
One of the two should be chosen.

```markdown
foo
**foo**
!!! note "Admonition"
```

In the previous state, the "foo" text would be completely obliterated, but now it will be kept, and the admonition will be rendered as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants