-
Notifications
You must be signed in to change notification settings - Fork 877
Add require_changelog workflow action #1051
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This action checks that an update was made to any file in docs/change_log/ but only if changes were made to files in markdown/. Presumably, any changes outside of markdown/ do not affect the behavior and do not require a notation in the change_log. When a change_log entry is missing, a comment is added to the PR informing the PR author. If a later commit to the PR includes a change_log entry, then the comment is hidden. A comment should only be added once per PR.
I looked at the following actions before settling on the first one.
|
Hmm, well it seems to be working except for posting the comment. We're getting |
Well, that's annoying. Switching from the |
Setting the |
This action checks that an update was made to any file in docs/change_log/
but only if changes were made to files in markdown/. Presumably,
any changes outside of markdown/ do not affect the behavior and do not
require a notation in the change_log.
When a change_log entry is missing, a comment is added to the PR informing
the PR author. If a later commit to the PR includes a change_log entry,
then the comment is hidden. A comment should only be added once per PR.