Skip to content

update install requires to drop quotes #1197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 17, 2021
Merged

update install requires to drop quotes #1197

merged 1 commit into from
Nov 17, 2021

Conversation

liu-ziyang
Copy link
Contributor

closes #1196

verified that pip consider requirements are met if an older version of importlib-metadata is installed when quotes are present

@waylan
Copy link
Member

waylan commented Nov 17, 2021

Funny thing. I included the quotes around the version because they were required around the python_version (my recollection is that things wouldn't work without the quotes around python_version). It is ridiculous that the syntax is different. Therefore my position is that any tool which doesn't accept the quotes has a bug. That said, it seems like an awful lot of tools have this bug and I don't want to be dealing with a never-ending stream of bug reports...

@violuke
Copy link

violuke commented Nov 17, 2021

Thanks @waylan for resolving this 👍 I think it's a bit harsh to consider it a bug in Poetry/other tools when they follow the PEP to the letter, but I agree with the sentiment that they could be more forgiving, especially given that the PEP itself is a bit silly. Bug in the PEP maybe 😆

Either way, thanks for merging this so quickly, much appreciated

@espdev
Copy link

espdev commented Nov 17, 2021

@waylan

There is an absurd confusing dependency specification syntax. I agree, but better a bad standard than none.
Here is a grammar: https://www.python.org/dev/peps/pep-0508/#complete-grammar

@waylan
Copy link
Member

waylan commented Nov 17, 2021

FYI, we just released version 3.3.6 which should resolve this issue.

@facelessuser
Copy link
Collaborator

Glad this turned out to be an easy fix, even if it was confusing at first.

@bstivers
Copy link

bstivers commented Nov 29, 2021

FYI, we just released version 3.3.6 which should resolve this issue.

Didn't fix it for me. Removed 3.3.5 and reinstalled via poetry (and pip) and the warning still shows up. Pip did inform me of the yanked 3.3.5, but installed it anyway.

And the current project I am working on can't use 3.3.6 due to other dependency issues that 3.3.6 causes. Namely, spleeter requires importlib-metadata (>=3.0.0,<4.0.0). But 3.3.6 requires importlib-metadata (>=4.4). And not using spleeter isn't an option.

What fixed it for me was downgrading to 3.3.4.

@blacksun-V
Copy link

How to determine which package is causing the error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Latest version of markdown breaks chalice deployments in github workflows
7 participants