Move backslash unescaping to treeprocessor #1272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By unescaping backslash escapes in a treeprocessor, the text is properly escaped during serialization. Fixes Python-Markdown#1131. As it is recognized that varous third-party extensions may be calling the old class at `postprocessors.UnescapePostprocessor` the old class remains in the codebase, but has been deprecated and will be removed in a future release. The new class `treeprocessors.UnescapeTreeprocessor` should be used instead.
waylan
commented
Jul 13, 2022
| @@ -9,7 +9,7 @@ | |||
| <p>Right bracket: ]</p> | |||
| <p>Left paren: (</p> | |||
| <p>Right paren: )</p> | |||
| <p>Greater-than: ></p> | |||
| <p>Greater-than: ></p> | |||
There was a problem hiding this comment.
This is the one and only change in behavior in the existing tests. I'm okay with this, however, as technically this results in valid output. The reason for the change is that the angle bracket gets escaped during serialization. Previously, a placeholder was there during serialization, which was swapped out for the actual character later. The whole point of this change was to better ensure valid HTML output, so this is an acceptable change in behavior.
There was a problem hiding this comment.
Having unescaped > in HTML was a bug, so good that you fixed it.
| """ Loop over all elements and unescape all text. """ | ||
| for elem in root.iter(): | ||
| # Unescape text content | ||
| if elem.text and not elem.tag == 'code': |
There was a problem hiding this comment.
I'm not sure we actually need to skip code tags, In fact, if I remove the check, the tests all pass. In fact, the previous code did not have a way to distinguish between code and other content. However, there is always a possibility that code could intentionally contain what looks like a placeholder. In that case, the content should not be altered. Therefore, I have left the check in.
|
I'll try and look at this soon. I'd like to pull it and see how it impacts some of my things. |
mitya57
approved these changes
Jul 14, 2022
facelessuser
approved these changes
Jul 14, 2022
andersk
added a commit
to andersk/zulip
that referenced
this pull request
Feb 4, 2023
See Python-Markdown/markdown#1272. Signed-off-by: Anders Kaseorg <[email protected]>
andersk
added a commit
to andersk/typeshed
that referenced
this pull request
Feb 4, 2023
This replaced the deprecated `markdown.postprocessors.UnescapePostprocessor` in Python-Markdown/markdown#1272. Signed-off-by: Anders Kaseorg <[email protected]>
andersk
added a commit
to andersk/typeshed
that referenced
this pull request
Feb 4, 2023
This replaced the deprecated `markdown.postprocessors.UnescapePostprocessor` in Python-Markdown/markdown#1272. Signed-off-by: Anders Kaseorg <[email protected]>
andersk
added a commit
to andersk/zulip
that referenced
this pull request
Feb 4, 2023
See Python-Markdown/markdown#1272. Signed-off-by: Anders Kaseorg <[email protected]>
andersk
added a commit
to andersk/typeshed
that referenced
this pull request
Feb 4, 2023
This replaced the deprecated `markdown.postprocessors.UnescapePostprocessor` in Python-Markdown/markdown#1272. Signed-off-by: Anders Kaseorg <[email protected]>
andersk
added a commit
to andersk/typeshed
that referenced
this pull request
Feb 4, 2023
This replaced the deprecated `markdown.postprocessors.UnescapePostprocessor` in Python-Markdown/markdown#1272. Signed-off-by: Anders Kaseorg <[email protected]>
timabbott
pushed a commit
to zulip/zulip
that referenced
this pull request
Feb 5, 2023
See Python-Markdown/markdown#1272. Signed-off-by: Anders Kaseorg <[email protected]>
andersk
added a commit
to andersk/typeshed
that referenced
this pull request
Feb 9, 2023
This replaced the deprecated `markdown.postprocessors.UnescapePostprocessor` in Python-Markdown/markdown#1272. Signed-off-by: Anders Kaseorg <[email protected]>
AlexWaygood
pushed a commit
to python/typeshed
that referenced
this pull request
Feb 9, 2023
This replaced the deprecated `markdown.postprocessors.UnescapePostprocessor` in Python-Markdown/markdown#1272. Signed-off-by: Anders Kaseorg <[email protected]>
UjjwalAggarwal-1
pushed a commit
to UjjwalAggarwal-1/zulip
that referenced
this pull request
Feb 20, 2023
See Python-Markdown/markdown#1272. Signed-off-by: Anders Kaseorg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By unescaping backslash escapes in a treeprocessor, the text is properly
escaped during serialization. Fixes #1131.
As it is recognized that varous third-party extensions may be calling the
old class at
postprocessors.UnescapePostprocessorthe old class remainsin the codebase, but has been deprecated and will be removed in a future
release. The new class
treeprocessors.UnescapeTreeprocessorshould beused instead.