Bug on 3.0.0

[arnauddorgans]

Since 3.0.0 WebImage is not able to update its URL

on v2.2.7

Screen.Recording.2024-03-16.at.03.12.07.mov

on v3.0.0

Screen.Recording.2024-03-16.at.03.16.16.mov

Full code

struct ContentView: View {
    @State var isOn = false

    var url: URL? {
        if isOn {
            .init(string: "https://upload.wikimedia.org/wikipedia/commons/thumb/c/c1/Google_%22G%22_logo.svg/1024px-Google_%22G%22_logo.svg.png")
        } else {
            nil
        }
    }

    var body: some View {
        VStack {
            WebImage(url: url)
                .resizable()
                .scaledToFit()
                .frame(width: 50, height: 50)
            Button("Toggle") {
                isOn.toggle()
            }
        }
    }
}

I found a workaround by setting .id(url) but I don't think this is optimized

[arnauddorgans]

I have the same issue on AnimatedImage but only when switching between nil and non nil URL

[dreampiggy]

nil url only ? What's your SDWebImage version, please provide the full Pod version (upload your Podfile.lock)

A reproduce demo is better.

[dreampiggy]

I found a workaround by setting .id(url) but I don't think this is optimized

@arnauddorgans Actually, I compare the 2.x and master branch and found this.

I guess this cause issue ? Why does we still need this identifier ? Is nil url special ?

Changes from: https://github.com/SDWebImage/SDWebImageSwiftUI/pull/275/files#diff-3974fffe08b7e38a73e0eec23be717410f40a5506bb8ac8ed60920e56f879390L299

[dreampiggy]

I have the same issue on AnimatedImage but only when switching between nil and non nil URL

@arnauddorgans Is that the same issue ? Or is that because of something optimized by me which does not trigger the view update when url is nil ?

[dreampiggy]

Fixed in v3.0.1

[arnauddorgans]

It works perfectly now, thanks! ❤️