-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
K8s: Video recorder run as sidecar container is disabled by default #2843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
CI Feedback 🧐(Feedback updated until commit 9c95cde)A test triggered by this PR failed. Here is an AI-generated analysis of the failure:
|
Signed-off-by: Viet Nguyen Duc <[email protected]>
d697dbb
to
9c95cde
Compare
User description
Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
From chart version
0.44.0+
, by default, the video recorder is not running as sidecar container anymore. Recording function will be performed in browser node container itself (check out the implementation).If you want to enable the video recorder as a sidecar container, you can set the following values:
Motivation and Context
Types of changes
Checklist
PR Type
enhancement, documentation
Description
Make video recorder sidecar container disabled by default
sidecarContainer
flag to video recorder configUpdate documentation for new video recorder behavior
Update test and Makefile logic for sidecarContainer option
Changes walkthrough 📝
_helpers.tpl
Conditional Helm templating for video recorder sidecarContainer option
charts/selenium-grid/templates/_helpers.tpl
recorder.sidecarContainer
in Helm templatessidecarContainer
is trueflag
values.yaml
Add sidecarContainer option to videoRecorder values
charts/selenium-grid/values.yaml
sidecarContainer
option to videoRecorder configREADME.md
Document new video recorder sidecarContainer default and usage
charts/selenium-grid/README.md
CONFIGURATION.md
Document sidecarContainer option in configuration reference
charts/selenium-grid/CONFIGURATION.md
videoRecorder.sidecarContainer
to configuration tablechart_test.sh
Add test logic for videoRecorder.sidecarContainer option
tests/charts/make/chart_test.sh
Makefile
Update Makefile to test videoRecorder sidecarContainer mode
Makefile