Fix broadcast stack overflow #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

MilesCranmer merged 1 commit into SymbolicML:arrays-2 from gaurav-arya:ag-stackoverflow

Sep 8, 2023

Collaborator

gaurav-arya commented Sep 8, 2023

Presumably on 1.10 the broadcast/convert logic is smart enough to not call that convert method in the first place. Mirrors logic in e.g. https://github.com/JuliaLang/julia/blob/b3741c01f2e2d4956be3ba41858c4065c6fbc7e8/base/array.jl#L663


          Fix broadcast stack overflow

d207332

Member

MilesCranmer commented Sep 8, 2023

Good catch!! Thanks

MilesCranmer merged commit 25d010c into SymbolicML:arrays-2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet