Added Processing language + BogoSort implementation #436

johhnry · 2018-10-03T21:28:20Z

Added a new language, Processing.
Processing is a Java based programming language used for computer graphics, data visualisation, animation...
Checkout https://processing.org/.

Added the Processing version of the Bogo Sort algorithm with sorting visualisation.

leios

Not used to the processing language. I asked a few questions, also the randomize() function seems a bit odd, but maybe I am just misreading it.

leios · 2018-10-03T21:48:35Z

book.json

@@ -139,6 +139,10 @@
        {
          "lang": "f90",
          "name": "Fortran90"
+        },
+        {
+          "lang": "processing",


I think lang should be the file extension, which is pde in this case.

Yes you are right, do I need to change that in the Pull request?

@johhnry Yep. Just push your changes to the branch you made this PR from.

leios · 2018-10-03T21:49:37Z

contents/bogo_sort/code/processing/bogoSort.pde

+  random_array(test_array,0,100);
+}
+
+void draw(){


Dumb question about processing. Does everything require a visual output?

It's not a requirement but Processing language was created for that kind of task.
I found it nice to visualize the sorting process.

leios · 2018-10-03T21:50:26Z

contents/bogo_sort/code/processing/bogoSort.pde

+  return true;
+}
+
+void bogo_Sort(int[] array){


It seems like we are mixing camel case and snake case here. We should probably choose one.

Is it possible to change the code of a pull request?

Just commit to the branch you have in your forked repo and the PR automatically updates. Read carefully the contributing tutorial!

contents/bogo_sort/code/processing/bogoSort.pde

Butt4cak3 · 2018-10-05T09:44:56Z

I'm not sure if we need this. The algorithms themselves are almost just plain Java and everything this adds on top is the visualization code which doesn't really help to teach the algorithms.

c252 · 2018-10-06T11:54:57Z

this is a small thing, but you have merge conflicts in book.json and bogo_sort.md

You can also use frame.setVisible(false); in processing if you decide you don't want to have the drawing window and just print to the console.

johhnry · 2018-10-07T10:33:51Z

@Butt4cak3
If you think it's not relevant to add visualisation to the algorithm, we don't need to merge the pull request.
I just think that it adds something to the algorithm, otherwise I could just implement Bogo sort in Java as Processing is Java-based.

jiegillet · 2018-10-07T11:19:45Z

I wrote some visualization before, it was in Elm in the Euler method chapter. We discussed a bunch, and I ended up displaying the parts relevant to the algorithm, then the full code after, along with a link to my GitHub.io with the interactive visualization.
Is something like that doable for you?
My opinion is that visualizations are great to learn.

leios · 2018-10-07T11:20:28Z

I don't think processing can run in gitbook, though?

johhnry · 2018-10-07T11:22:37Z

@leios
Processing can't run in gitbook but there's p5.js (https://p5js.org/) in JavaScript.

jiegillet · 2018-10-07T11:24:04Z

I don't think we should go down the road of adding that to the AAA, but if you have a personal page, you should definitely set it up there and add a link

Butt4cak3 · 2018-10-07T11:59:42Z

Now we're getting back to the old discussion about interactive visualizations in the AAA, which we have turned down in the past (see HOVL).

johhnry · 2018-10-07T13:36:00Z

@Butt4cak3
What was the conclusion?

johhnry · 2018-10-07T16:06:32Z

I just saw that there's an animation in this page : https://www.algorithm-archive.org/contents/monte_carlo_integration/monte_carlo_integration.html

It could be nice to add the same thing for other algorithms (visualization) by using gif.

Butt4cak3 · 2018-10-08T16:24:12Z

@Butt4cak3
What was the conclusion?

Well... We turned it down. No interactive visualization in the AAA.

johhnry · 2018-10-08T20:26:34Z

Sorry if I am asking a lot of questions but why book.json and contents/bogo_sort/bogo_sort.md are they in conflict? How do we resolve that?

Thanks for giving your time

leios · 2018-10-08T22:13:19Z

Hey @johhnry. We have an elm visualization for the forward euler method; however, that remains the only interactive visualization in the AAA so far. Even then, there was a heated debate as to whether it should be added in. Processing cannot be a dynamic visualization on the algorithm-archive.org (P5.js can, though?).

Is the processing implementation of the algorithm (without the boilerplate visualization) different than Java?

My understanding is that they are literally the same, except that the processing code is dropped into a Java class when the code is compiled. I am conflicted here. On the one hand, it looks like Processing is much easier to read and write than Java; however, if the implementation is literally the same, then no one will really be able to tell the difference in the AAA.

This is a good discussion to have, so even if we decide to turn this PR down, it was really helpful. I would like to hear opinions from both sides.

jiegillet · 2018-10-08T23:00:25Z

Another idea is having @johhnry work with @leios on a quality animation, like a gif, and have it displayed in a chapter, like we have in Monte Carlo or Split-Op. We can leave a note at the end saying that the visualization was done in Processing and show the code. I think that would be wonderful and very useful to people.

leios · 2018-10-08T23:24:55Z

Yeah, I agree with that @jiegillet. The only problem here is that for consistency, if we use one visualization method for Bogo Sort, we should use the same one for all the other sorts (and there are a lot of them). It's fine, so long as @johhnry is willing to help as more sorting chapters get added.

jiegillet · 2018-10-08T23:45:57Z

I don't think consistency is a priority, if only one chapter has a visualization, it's better than nothing. If more do, all the better.

johhnry · 2018-10-09T08:45:29Z

It's fine, so long as @johhnry is willing to help as more sorting chapters get added.

I would love to!
I think it will add more interactivity to the algorithm archive gitbook.

johhnry · 2018-10-09T14:06:27Z

Really simple example for Bubble sort algorithm :

leios · 2018-10-09T21:12:30Z

So what was the verdict on this PR? Do we close it and create a separate issue to discuss the visualization of sorting algorithms? Or do we keep it up and rework it for a general-case visualization with code available?

jiegillet · 2018-10-10T01:17:58Z

@johhnry very nice!
I think you should add more colors to differentiate the pairs being compared and switched.

leios · 2018-10-10T01:21:40Z

I think it would be understandable enough to highlight the two bars we are comparing. Once we have the visualization done, I'll send you a PR on this PR for you to merge so we can merge.

johhnry · 2018-10-10T20:15:02Z

Here is my second try :

jiegillet · 2018-10-11T01:04:58Z

Looks good! I would work on the timings a bit more. The swap is too slow and the non-swap are too fast :)

leios · 2018-10-11T01:09:46Z

I like the visualization. If you fix the timings, it will be great!

That said, isn't that visualization for Bubble sort? This is a Bogo Sort PR. I can just change the name to Bubble Sort, though.

johhnry · 2018-10-11T07:32:26Z

Looks good! I would work on the timings a bit more. The swap is too slow and the non-swap are too fast :)

Yes you are totally right

@leios
I also want to make the visualization for Bogo sort so we can rename the PR to "sorting visualization" ?

johhnry · 2018-10-11T22:58:20Z

Bogo Sort visualization (maybe on more elements) :

Bubble Sort :

jiegillet · 2018-10-11T23:58:56Z

Love it!
I would add a few more elements to the bogoSort array. Should it end on a sorted array and turn green maybe? That would show that the algorithm can finish, but I admit that an endless loops of shuffling is way funnier (but in this case, you have to make the first and last frame identical so that it's a smooth loop)

Bubble sort is good but it stops before the array is sorted, that's frustrating, maybe you can remove one or 2 elements. Also most AAA algorithm don't have the optimization of not going through the whole array when then end is already sorted, so maybe you shouldn't either. I'm not sure...

leios · 2018-10-12T00:04:04Z

Agreed, these are good. It would be nice if both of them finished on sorted arrays and waited for a second or something.

johhnry · 2018-10-17T19:31:53Z

Bogo Sort :

leios · 2018-10-21T21:20:21Z

Alright, I am happy with this visualization. Let me send a PR to your PR about this.

johhnry · 2018-11-29T21:30:26Z

What's up guys ?
@leios Did you send me a PR?

leios · 2018-12-15T03:30:35Z

I have not. I've just been swamped lately.

leios · 2018-12-24T00:58:35Z

I finally got the PR in: https://github.com/johhnry/algorithm-archive/pull/2

adding processing visualization and small merges.

leios · 2019-01-10T10:05:52Z

Hey @johhnry thanks a lot! Do you have a video of this animation as well? We have recently changed things to videos, if possible. If you don't have a video, no problem!

johhnry · 2019-01-10T10:38:37Z

Sure, how do I send it ? on Github?

Amaras · 2021-08-22T21:58:57Z

Since the repository has been deleted, I don't think it's merge-able any more, sadly.
Also, we don't have sorting chapters any more, so this is now a dead PR.
I'm closing it, though it's a shame it has not been given the attention it deserved.

Added Processing language + BogoSort

bcd6a56

Gathros added Implementation This provides an implementation for an algorithm. (Code and maybe md files are edited.) Hacktoberfest The label for all Hacktoberfest related things! labels Oct 3, 2018

leios reviewed Oct 3, 2018

View reviewed changes

johhnry added 2 commits October 7, 2018 13:33

change

52e4c29

changed lang to pde in book.json

3cee797

johhnry closed this Oct 14, 2018

johhnry reopened this Oct 14, 2018

adding processing visualization and small merges.

782cbc1

johhnry and others added 2 commits January 10, 2019 10:59

Merge pull request #2 from leios/johhnry_updates

7bfb564

adding processing visualization and small merges.

Merge branch 'master' into bogo_sort_processing

301f188

Amaras closed this Aug 22, 2021

Uh oh!

Added Processing language + BogoSort implementation #436

Added Processing language + BogoSort implementation #436

Uh oh!

Conversation

johhnry commented Oct 3, 2018

Uh oh!

leios left a comment

Choose a reason for hiding this comment

Uh oh!

leios Oct 3, 2018

Choose a reason for hiding this comment

Uh oh!

johhnry Oct 4, 2018

Choose a reason for hiding this comment

Uh oh!

nic-hartley Oct 5, 2018

Choose a reason for hiding this comment

Uh oh!

leios Oct 3, 2018

Choose a reason for hiding this comment

Uh oh!

johhnry Oct 4, 2018

Choose a reason for hiding this comment

Uh oh!

leios Oct 3, 2018

Choose a reason for hiding this comment

Uh oh!

johhnry Oct 4, 2018

Choose a reason for hiding this comment

Uh oh!

Yordrar Oct 4, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Butt4cak3 commented Oct 5, 2018

Uh oh!

c252 commented Oct 6, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

johhnry commented Oct 7, 2018

Uh oh!

jiegillet commented Oct 7, 2018

Uh oh!

leios commented Oct 7, 2018

Uh oh!

johhnry commented Oct 7, 2018

Uh oh!

jiegillet commented Oct 7, 2018

Uh oh!

Butt4cak3 commented Oct 7, 2018

Uh oh!

johhnry commented Oct 7, 2018

Uh oh!

johhnry commented Oct 7, 2018

Uh oh!

Butt4cak3 commented Oct 8, 2018

Uh oh!

johhnry commented Oct 8, 2018

Uh oh!

leios commented Oct 8, 2018

Uh oh!

jiegillet commented Oct 8, 2018

Uh oh!

leios commented Oct 8, 2018

Uh oh!

jiegillet commented Oct 8, 2018

Uh oh!

johhnry commented Oct 9, 2018

Uh oh!

johhnry commented Oct 9, 2018

Uh oh!

leios commented Oct 9, 2018

Uh oh!

jiegillet commented Oct 10, 2018

Uh oh!

leios commented Oct 10, 2018

Uh oh!

johhnry commented Oct 10, 2018

Yordrar Oct 4, 2018 •

edited

Loading

c252 commented Oct 6, 2018 •

edited

Loading

johhnry commented Oct 11, 2018 •

edited

Loading

johhnry commented Oct 11, 2018 •

edited

Loading

leios commented Dec 24, 2018 •

edited

Loading