Skip to content

Support to use Func<IServiceProvider, AWSOptions> to create AWSOptions object. #1958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

isdaniel
Copy link
Contributor

@isdaniel isdaniel commented Dec 20, 2021

Support to use Func<IServiceProvider, AWSOptions> to create AWSOptions object.

Description

Add an extension method that supports users can use DI Container objects setting to create AWSOptions object.

Motivation and Context

This PR was an enhancement for #1957,

Testing

I wrote some unit tests for this modify

Screenshots (if appropriate)

AWSSDK.Extensions test result.

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed

License

  • I confirm that this pull request can be released under the Apache 2 license

Support to use Func<IServiceProvider, AWSOptions> to create AWSOptions object.
@isdaniel isdaniel changed the title Update ServiceCollectionExtensions.cs Support to use Func<IServiceProvider, AWSOptions> to create AWSOptions object. Dec 20, 2021
@ppittle ppittle self-requested a review February 15, 2022 23:01
@ppittle
Copy link
Contributor

ppittle commented Feb 16, 2022

Thank you for your PR. I have this staged internally for an upcoming manual release of the SDK (TBD, as opposed to the daily release with service updates).

@isdaniel
Copy link
Contributor Author

Thanks for your notification!

@ppittle
Copy link
Contributor

ppittle commented Mar 10, 2022

PR has been merged by our build system:

@ppittle ppittle closed this Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants