Skip to content

Optimize ParameterAsString #3363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 4, 2024

Conversation

danielmarbach
Copy link
Contributor

@danielmarbach danielmarbach commented Jun 29, 2024

For now I continue a bit on the path to use ValueStringBuilder where StringBuilders are used. There is probably even more room for optimizations but it seems a low effort way to get some gains

Description

Motivation and Context

image

https://github.com/danielmarbach/aws-sdk-net-benchmarks/blob/main/ParameterAsString.cs

Testing

I have added a test that verifies the current functionality works and then applied the optimizations which still pass the same test

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed

License

  • I confirm that this pull request can be released under the Apache 2 license

@danielmarbach danielmarbach changed the base branch from main to v4-development June 29, 2024 13:32
@danielmarbach danielmarbach changed the base branch from v4-development to v4-development-merge June 29, 2024 13:34
@danielmarbach danielmarbach changed the base branch from v4-development-merge to v4-development June 29, 2024 13:35
@dscpinheiro dscpinheiro added the v4 label Jun 30, 2024
@danielmarbach
Copy link
Contributor Author

I will add a test to check the before and after

@danielmarbach
Copy link
Contributor Author

@normj @dscpinheiro this is ready

@danielmarbach
Copy link
Contributor Author

FYI I will be going on vacation end of this week and probably become unresponsive for at least three weeks

@dscpinheiro dscpinheiro merged commit 37a9afe into aws:v4-development Jul 4, 2024
@danielmarbach danielmarbach deleted the parameter_as_string branch July 4, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants