Skip to content

Add base class for upcoming object persistence operation-specific config objects #3380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 10, 2024

Conversation

ashovlin
Copy link
Member

Description

This is adding a base class to use for the new set of operation-specific config objects for the object persistence APIs.

Motivation and Context

See #3376 for the full context for this change, this PR came from #3376 (comment). I'd rather merge this into the feature branch quickly, then rebase the PRs that are introducing the derived classes on top of it.

Testing

Existing DynamoDBv2 sln tests pass.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed

License

  • I confirm that this pull request can be released under the Apache 2 license

@ashovlin ashovlin force-pushed the shovlia/v4-ddb-separate-base branch from 3e03c1e to 19ff23e Compare July 10, 2024 19:35
@ashovlin ashovlin requested a review from 96malhar July 10, 2024 19:36
@ashovlin ashovlin merged commit 41f9ab8 into feature/v4-ddb-separate-config Jul 10, 2024
1 check passed
@ashovlin ashovlin deleted the shovlia/v4-ddb-separate-base branch July 10, 2024 19:42
ashovlin added a commit that referenced this pull request Aug 7, 2024
ashovlin added a commit that referenced this pull request Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants