Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: bazelbuild/buildtools
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v8.0.3
Choose a base ref
...
head repository: bazelbuild/buildtools
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v8.2.0
Choose a head ref
  • 15 commits
  • 22 files changed
  • 10 contributors

Commits on Mar 5, 2025

  1. Clean up redundant recommendation from README.md (#1337)

    Removing redundant recommendation to run movePackageToTop, there doesn't seem to be any reason to do so
    oreflow authored Mar 5, 2025
    Configuration menu
    Copy the full SHA
    17d06ff View commit details
    Browse the repository at this point in the history
  2. Remove "out" from the listArg-list (#1338)

    "out" as an attribute seems to be a list and a string literal, varying between different rules.
    
    From a lexical standpoint, it would be more likely to be a singluar value as the the wording is singular, and it would be more expected for a rule which provides multiple outs to use the "outs" attribute.
    
    Metrics (based on Google internal use) show use of the attribute are ~5% lists, and ~95% string.
    oreflow authored Mar 5, 2025
    Configuration menu
    Copy the full SHA
    bc03ae5 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    63f93c1 View commit details
    Browse the repository at this point in the history
  4. Update CODEOWNERS (#1340)

    vladmos authored Mar 5, 2025
    Configuration menu
    Copy the full SHA
    7cb8bf6 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2025

  1. Configuration menu
    Copy the full SHA
    931d76d View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2025

  1. Break module extension groups after a use_repo (#1339)

    This allows users to separate tags and associated `use_repo` statements into separate groups.
    
    Also use unified diffs in the integration tests since ordinary diffs make it very hard to reason about whitespace.
    
    Before:
    ```
    go_deps = use_extension("//:extensions.bzl", "go_deps")
    go_deps.from_file(go_mod = "//:go.mod")
    use_repo(
        go_deps,
        "com_github_bazelbuild_buildtools",
    )
    go_deps.module(name = "foo")
    use_repo(go_deps, "foo")
    ```
    
    After:
    ```
    go_deps = use_extension("//:extensions.bzl", "go_deps")
    go_deps.from_file(go_mod = "//:go.mod")
    use_repo(
        go_deps,
        "com_github_bazelbuild_buildtools",
    )
    
    go_deps.module(name = "foo")
    use_repo(go_deps, "foo")
    ```
    fmeum authored Mar 12, 2025
    Configuration menu
    Copy the full SHA
    737aaf8 View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2025

  1. Configuration menu
    Copy the full SHA
    ee6c0a3 View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2025

  1. Configuration menu
    Copy the full SHA
    f79c8ea View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2025

  1. Note that list-append incorrectly warns on select statements (#1348)

    * Note that list-append incorrectly warns on select statements
    
    * rephrase informal sentence
    
    * regenerate .md
    
    * Rephrasing warning
    
    ---------
    
    Co-authored-by: Philipp Ollendorff <[email protected]>
    pollendo and Philipp Ollendorff authored Apr 3, 2025
    Configuration menu
    Copy the full SHA
    c98d8e8 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2025

  1. Direct users to disable incorrect warning (#1349)

    Co-authored-by: Philipp Ollendorff <[email protected]>
    pollendo and Philipp Ollendorff authored Apr 4, 2025
    Configuration menu
    Copy the full SHA
    f963a97 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2025

  1. Removing unused directory buildifier2 (#1350)

    Co-authored-by: Tim Malmström <[email protected]>
    oreflow and Tim Malmström authored Apr 10, 2025
    Configuration menu
    Copy the full SHA
    16e6ff5 View commit details
    Browse the repository at this point in the history
  2. Adding nil check for Rule Call Expression (#1351)

    Rules can currently be created with CallExpr set to nil, which results in the code panicking. Checking for this error and using the type default if there is no other value defined.
    
    Co-authored-by: Tim Malmström <[email protected]>
    oreflow and Tim Malmström authored Apr 10, 2025
    Configuration menu
    Copy the full SHA
    f37c35d View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2025

  1. Keep targets like "@foo//:foo" formatted as-is. (#1355)

    * Keep targets like "@foo//:foo" formatted as-is.
    
    See #1354
    
    * Update 019.build.golden
    
    Update golden file.
    laramiel authored Apr 25, 2025
    Configuration menu
    Copy the full SHA
    870ee1b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5b1eedd View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2025

  1. Bug fix. Correctly identify expressions using &=, ^=, >>=, and <<= as…

    … assignment statements when parsing BUILD files. (#1357)
    
    * Add files via upload
    
    Correctly include &=, ^=, >>=, <<= as assignment statements when parsing BUILD files.
    
    The Starlark grammar reference (https://github.com/bazelbuild/starlark/blob/master/spec.md#grammar-reference) identifies all of these as assignment statements, but the parser doesn't include them in the list, probably an old oversight.
    
    This fixes issue #1330.
    
    * Update warn_control_flow_test
    
    This change adds no-effect tests for &=, ^=, >>=, and <<= to ensure they are recognized as having an effect.
    pdoyle12 authored Apr 27, 2025
    Configuration menu
    Copy the full SHA
    d9ed52a View commit details
    Browse the repository at this point in the history
Loading