[BUG] Workaround for ESP32 hw timer library calls not in IRAM. #1351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixes a crash on the ESP32 platform.
* Rename the global var `timer` to something that should not colide easily.
* Manipulate the ESP32 hw timers directly rather than through the library interface.
- Required because the following lib calls are not in IRAM by default.
* `timerWrite();`
* `timerAlarmEnable()`
* This a horrible kludge/hack/mess!
Fixes #1350 (Hopefully!)
|
Could we have the timer rename part in a separate "safe" commit? And then have only the "kludge" here? That way any reverts are needed it would be cleaner? |
* We'll do this in a separate commit/PR instead. Ref: #1350
Fair point. I've reverted the variable rename. I'll do it as a separate PR after we confirm it fixes the problem in #1350 & merge this one. |
NiKiZe
approved these changes
Dec 1, 2020
|
Confirmed fixed in #1350 (comment) |
This was referenced Dec 3, 2020
crankyoldgit
added a commit
that referenced
this pull request
Jan 3, 2021
**[Bug Fixes]** - SanyoAc: Fix Sensor Location error (#1359) - IRMQTTServer: Compiler error under PlatformIO on Windows. (#1353 #1354) - Workaround for ESP32 hw timer library calls not in IRAM. (#1350 #1351) **[Features]** - PANASONIC_AC32: Add limited detailed support. (#1364 #1366) - Move global vars in IRrecv into a namespace. (#1350 #1352) - Fujitsu: Handle toggles of Econo & Turbo when `IRac` interface is used. (#1334 #1345) **[Misc]** - Elitescreens: Update supported brands/models (#1375) - refactor ir_Sharp (#1374) - refactor ir_Sanyo (#1359) - Gree: List Amana as supported. (#1361 #1363) - Lasertag: Increase matching tolerance. (#1360 #1362) - refactor ir_Samsung (#1358) - refactor ir_Neoclima (#1349) - Update issue templates (#1348 #1355) - Midea: Update supported devices & add notes for an odd Pioneer System. (#1342 #1344) - Kelvinator: Update supported models. (#1335 #1346)
Merged
crankyoldgit
added a commit
that referenced
this pull request
Jan 4, 2021
## _v2.7.14 (20210103)_ **[Bug Fixes]** - SanyoAc: Fix Sensor Location error (#1359) - IRMQTTServer: Compiler error under PlatformIO on Windows. (#1353 #1354) - Workaround for ESP32 hw timer library calls not in IRAM. (#1350 #1351) **[Features]** - PANASONIC_AC32: Add limited detailed support. (#1364 #1366) - Move global vars in IRrecv into a namespace. (#1350 #1352) - Fujitsu: Handle toggles of Econo & Turbo when `IRac` interface is used. (#1334 #1345) **[Misc]** - Elitescreens: Update supported brands/models (#1375) - refactor ir_Sharp (#1374) - refactor ir_Sanyo (#1359) - Gree: List Amana as supported. (#1361 #1363) - Lasertag: Increase matching tolerance. (#1360 #1362) - refactor ir_Samsung (#1358) - refactor ir_Neoclima (#1349) - Update issue templates (#1348 #1355) - Midea: Update supported devices & add notes for an odd Pioneer System. (#1342 #1344) - Kelvinator: Update supported models. (#1335 #1346)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manipulate the ESP32 hw timers directly rather than through the library interface.
timerWrite();timerAlarmEnable()Tested on a ESP8266 NodeMCU & a ESP32dev board. Working as expected.
Fixes #1350