Remove await for WASM platform.callEntryPoint
#31997
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HaoK
reviewed
Apr 20, 2021
HaoK
approved these changes
Apr 20, 2021
10 tasks
mkArtakMSFT
pushed a commit
that referenced
this pull request
Apr 21, 2021
## Description Regression introduced via: #31769 * On Blazor Server, `Blazor.start` returns a promise that resolves when the .NET code starts up and the app becomes interactive * On WebAssembly: * Prior to #31769, `Blazor.start` behaves the same as server (the promise resolves when the app becomes interactive) * Since #31769, `Blazor.start` returns a promise that doesn’t resolve until the .NET app exits, which typically means never, and hence prevents its usage for triggering post-.NET startup logic This PR is meant to revert that specific bit of logic, so that we no longer await the `platform.callEntryPoint` function and thus `Blazor.start` returns a promise that resolves when the .NET code starts up and the app becomes interactive. This now matches the behavior from 6.0-preview3. ## Customer Impact Without this PR we inadvertently introduce a breaking change where the `Blazor.start` promise doesn't resolve until the .NET app exits. This prevents its usage for triggering post-.NET startup logic. ## Regression? - [x] Yes - [ ] No [If yes, specify the version the behavior has regressed from]: Regression from 6.0-preview3 Regressed by: #31769 ## Risk - [ ] High - [ ] Medium - [x] Low [Justify the selection above] Returning the `await` logic to what it was prior to #31769 which was introduced in Preview 4. ## Verification - [x] Manual (required) - [x] Automated: #31997 ## Packaging changes reviewed? - [ ] Yes - [ ] No - [x] N/A Addresses #31971
3dots
pushed a commit
to 3dots/aspnetcore-Web.JS
that referenced
this pull request
Feb 19, 2024
## Description Regression introduced via: #31769 * On Blazor Server, `Blazor.start` returns a promise that resolves when the .NET code starts up and the app becomes interactive * On WebAssembly: * Prior to #31769, `Blazor.start` behaves the same as server (the promise resolves when the app becomes interactive) * Since #31769, `Blazor.start` returns a promise that doesn’t resolve until the .NET app exits, which typically means never, and hence prevents its usage for triggering post-.NET startup logic This PR is meant to revert that specific bit of logic, so that we no longer await the `platform.callEntryPoint` function and thus `Blazor.start` returns a promise that resolves when the .NET code starts up and the app becomes interactive. This now matches the behavior from 6.0-preview3. ## Customer Impact Without this PR we inadvertently introduce a breaking change where the `Blazor.start` promise doesn't resolve until the .NET app exits. This prevents its usage for triggering post-.NET startup logic. ## Regression? - [x] Yes - [ ] No [If yes, specify the version the behavior has regressed from]: Regression from 6.0-preview3 Regressed by: #31769 ## Risk - [ ] High - [ ] Medium - [x] Low [Justify the selection above] Returning the `await` logic to what it was prior to dotnet/aspnetcore#31769 which was introduced in Preview 4. ## Verification - [x] Manual (required) - [x] Automated: dotnet/aspnetcore#31997 ## Packaging changes reviewed? - [ ] Yes - [ ] No - [x] N/A Addresses dotnet/aspnetcore#31971
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added an E2E test.
Addresses #31971
Insertion into preview 4: #31978