Skip to content

Remove unused field from HttpRequestHeaders enumerator #32234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2021

Conversation

benaadams
Copy link
Member

@benaadams benaadams commented Apr 28, 2021

And associated work assigning it. This can be a hot path in situations where Kestrel is being used as a proxy and all its request headers are enumerated.

Fixes #32233

@Tratcher
Copy link
Member

Needs rebasing.

@Tratcher Tratcher added the pr: pending author input For automation. Specifically separate from Needs: Author Feedback label Apr 28, 2021
@benaadams benaadams force-pushed the HttpRequestHeaders branch from e0b78c2 to 0857f01 Compare April 28, 2021 18:44
@benaadams
Copy link
Member Author

Rebased

@Tratcher Tratcher added this to the 6.0-preview5 milestone Apr 28, 2021
@Tratcher Tratcher added auto-merge and removed pr: pending author input For automation. Specifically separate from Needs: Author Feedback labels Apr 28, 2021
@ghost
Copy link

ghost commented Apr 28, 2021

Hello @Tratcher!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@Tratcher Tratcher self-assigned this Apr 28, 2021
@benaadams
Copy link
Member Author

Should I rebase to restart CI?

@Tratcher
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@benaadams
Copy link
Member Author

Razor source generator issue again #32237

@Tratcher Tratcher merged commit 16138c9 into dotnet:main Apr 29, 2021
@Tratcher
Copy link
Member

Thanks

@benaadams benaadams deleted the HttpRequestHeaders branch April 29, 2021 22:58
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HttpRequestHeaders enumerator has unreferenced field
4 participants