-
Notifications
You must be signed in to change notification settings - Fork 10.4k
Unquarantine CanSendAndReceiveBytes #32281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Looks like a legitimate CI failure.
|
Right I don't have any context, but I noticed this too, our tests seem to interact with each other, my feeling is that there's too much parallelization/sharing of servers between our tests. It seems better to run our tests in a sandbox or at the least where its not possible to have this kind of interaction. I filed #31195 which was another set of tests that I encountered that cause each other to fail. You can probably add these tests to that list, and maybe you can try to identify what's causing the test interactions in our E2E tests |
Actually that bind error, is that our old caching friend @captainsafia ? |
I've made this suggestion before but got opposition from DOI, I think the quarantine runs should be running the full set of tests, not just the quarantined tests, that would dramatically increase the confidence that unquarantining tests actually is safe. |
The other issue occurs as a build error. This one is happening during runtime so I believe it is different. |
This test has been passing consistently for the past 30 days now:

(the 4 failures in the past 24 hours are due to an unrelated CI issue which has been separately investigated).
This is just an extension of: #31156
Underlying test stability issues should've been resolved in the October/November 2020 timeframe via #26519.
Edit: Also added independent Browser instances between
CanSendAndReceiveBytes
andBenchmarksRunWithoutError
. The flakiness seems to have been rooted in shared Browser instances between tests.Fixes: #23366