Fixed duplicate LoggerMessage EventNames in RemoteJSRuntime.cs file #47280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR, @shiladitya-mukerji-22. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
|
@dotnet-policy-service agree [company="Default"] |
|
@dotnet-policy-service agree |
Eilon
reviewed
Mar 20, 2023
|
Thanks for your PR, @shiladitya-mukerji-22. |
javiercn
approved these changes
Mar 27, 2023
|
@shiladitya-mukerji-22 thanks for the contribution @shiladitya-mukerji-22! |
|
The last bit is that I think we need to publish an announcement for the event name changes |
eerhardt
added a commit
to eerhardt/aspnetcore
that referenced
this pull request
Mar 27, 2023
These suppressions are no longer needed after dotnet#47280.
eerhardt
added a commit
that referenced
this pull request
Mar 28, 2023
These suppressions are no longer needed after #47280.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixing_duplicate_eventnames
In the RemoteJSRuntime.cs file EventNames of four Log Messages were duplicates of already existing names. So I modified the EventNames to make each one unique.
Description
Fixed duplicate LoggerMessage EventNames in RemoteJSRuntime.cs file
Fixes #46072