Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Optimize {Try}FormatDecimal #18935

Merged
merged 1 commit into from
Jul 18, 2018
Merged

Optimize {Try}FormatDecimal #18935

merged 1 commit into from
Jul 18, 2018

Conversation

pentp
Copy link

@pentp pentp commented Jul 16, 2018

This improves decimal formatting performance by 1.09x and removes an unused nMinDigits parameter from many functions.
Moved from dotnet/corert#6099 (comment)

@jkotas
Copy link
Member

jkotas commented Jul 17, 2018

@dotnet-bot test OSX10.12 x64 Checked CoreFX Tests please
@dotnet-bot test OSX10.12 x64 Checked Innerloop Build and Test please

Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jkotas jkotas merged commit fb37382 into dotnet:master Jul 18, 2018
@pentp pentp deleted the FormatDecimal branch July 18, 2018 11:10
dotnet-maestro-bot pushed a commit to dotnet-maestro-bot/corefx that referenced this pull request Jul 18, 2018
dotnet-maestro-bot pushed a commit to dotnet-maestro-bot/corert that referenced this pull request Jul 18, 2018
stephentoub pushed a commit to dotnet/corefx that referenced this pull request Jul 18, 2018
jkotas pushed a commit to dotnet/corert that referenced this pull request Jul 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants