Fix warnings found with new analyzer CA1860: Prefer Length/Count/IsEmpty property check over Any() #81583
Conversation
…y property support
|
Tagging subscribers to this area: @dotnet/area-meta Issue Details
|
| @@ -468,6 +468,9 @@ dotnet_diagnostic.CA1858.severity = warning | |||
| # CA1859: Use concrete types when possible for improved performance | |||
| dotnet_diagnostic.CA1859.severity = warning | |||
There was a problem hiding this comment.
Do things get out of hand if you turn on analysis of internal stuff too?
There was a problem hiding this comment.
By default it's only private and you can opt-in to internal as well? We should definitely aim to opt in.
There was a problem hiding this comment.
Yes, the default is private and you can opt-in to internal and public too.
Support for internal and public is in a PR that is about to be merged: dotnet/roslyn-analyzers#6421
There was a problem hiding this comment.
Yes, I tried with internal a lot flagged that looks valid, now dotnet/roslyn-analyzers#6421 is merged, probably better wait until it is ready for consumption for the repo before enable the internal API surface
Prefer Length/Count/IsEmpty property check over Any(), and updated its severity.