Skip to content

Update Base64StringAttribute.cs #86221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2023
Merged

Update Base64StringAttribute.cs #86221

merged 1 commit into from
May 14, 2023

Conversation

WeihanLi
Copy link
Contributor

Use Base64.IsValid for Base64StringAttribute

@ghost ghost added community-contribution Indicates that the PR has been added by a community member area-System.ComponentModel.DataAnnotations labels May 14, 2023
@ghost
Copy link

ghost commented May 14, 2023

Tagging subscribers to this area: @dotnet/area-system-componentmodel-dataannotations
See info in area-owners.md if you want to be subscribed.

Issue Details

Use Base64.IsValid for Base64StringAttribute

Author: WeihanLi
Assignees: -
Labels:

area-System.ComponentModel.DataAnnotations, community-contribution

Milestone: -

@stephentoub
Copy link
Member

nice, thanks

@stephentoub
Copy link
Member

@WeihanLi, any specific reason this is marked draft?

@tarekgh tarekgh marked this pull request as ready for review May 14, 2023 18:47
@tarekgh
Copy link
Member

tarekgh commented May 14, 2023

I think we can merge it now.

@stephentoub stephentoub merged commit 9dd59af into dotnet:main May 14, 2023
@WeihanLi
Copy link
Contributor Author

any specific reason this is marked draft?

@stephentoub many thanks, I marked it as a draft to see if it would fail some test cases

@WeihanLi WeihanLi deleted the patch-1 branch May 15, 2023 02:14
@ghost ghost locked as resolved and limited conversation to collaborators Jun 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.ComponentModel.DataAnnotations community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants