Improve error message if setting is not found #17230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can do better than just throwing an error when we don't find a setting. It's actually trivial to leverage lucenes slow LD StringDistance to find possible candiates for a setting to detect missspellings and suggest a possible setting. This commit adds error messages like: * `unknown setting [index.numbe_of_replica] did you mean [index.number_of_replicas]?` rather than just reporting the setting as unknown
|
thanks @rmuir for putting this on the table - it's an awesome idea :) |
|
+1, great improvement! just like the JDK. Note: if later we want better support for transpositions, there is also LuceneLevenshteinDistance and JaroWinkler which are geared at those too. Someone can always explore those, this one should do well though (esp with 0.7) |
|
+1, very cool! |
|
I wonder what is the levenshtein distance between a @rmuir and great features is :) |
|
LGTM |
| String msg = "unknown setting [" + key + "]"; | ||
| List<String> keys = scoredKeys.stream().map((a) -> a.v2()).collect(Collectors.toList()); | ||
| if (keys.isEmpty() == false) { | ||
| msg += " did you mean " + (keys.size() == 1 ? "[" + keys.get(0) + "]": "any of " + keys.toString()) + "?"; |
There was a problem hiding this comment.
I love this! This is so great for our users.
|
everything that prevents from staring at screen only to feel dumb later is great :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can do better than just throwing an error when we don't find a
setting. It's actually trivial to leverage lucenes slow LD StringDistance
to find possible candiates for a setting to detect missspellings and suggest
a possible setting.
This commit adds error messages like:
unknown setting [index.numbe_of_replica] did you mean [index.number_of_replicas]?rather than just reporting the setting as unknown