-
Notifications
You must be signed in to change notification settings - Fork 475
[PHP-FPM] Add Integration Package with Pool Data Stream #4603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PHP-FPM] Add Integration Package with Pool Data Stream #4603
Conversation
/test |
/test |
🚀 Benchmarks reportTo see the full report comment with |
🌐 Coverage report
|
LGTM |
@@ -0,0 +1,18 @@ | |||
FROM bitnami/php-fpm:8.1.12-debian-11-r4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Q:Are we not keeping this docker image in elastic repo? In here: https://container-library.elastic.co/
For Example which i can see in redis for beats repo: https://github.com/elastic/beats/blob/cd547c688521c6475120200fecd4cca29a05eb5b/metricbeat/module/redis/docker-compose.yml#L5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We never came across adding docker image in elastic repo till now. Also we do not have the access for the elastic repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Package php_fpm - 0.1.0 containing this change is available at https://epr.elastic.co/search?package=php_fpm |
What does this PR do?
Checklist
How to test this PR locally
elastic-package test
Related issues
Screenshots