Skip to content

[PHP-FPM] Add Integration Package with Pool Data Stream #4603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 24, 2022

Conversation

harnish-crest
Copy link
Contributor

@harnish-crest harnish-crest commented Nov 9, 2022

  • Enhancement

What does this PR do?

  • Added 1 data stream (Pool metrics).
  • Added data collection logic for the data streams.
  • Added the ingest pipeline for the data streams.
  • Mapped fields according to the ECS schema and added Fields metadata in the appropriate yaml files.
  • Added dashboards and visualizations.
  • Added system test cases for the data stream.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

  • Clone integrations repo.
  • Install elastic-package locally.
  • Start elastic stack using elastic-package.
  • Move to (integrations/packages/php_fpm) directory.
  • Run the following command to run tests.
    elastic-package test

Related issues

Screenshots

php_fpm-pool-dashboard

@elasticmachine
Copy link

elasticmachine commented Nov 9, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-11-15T16:59:43.331+0000

  • Duration: 15 min 45 sec

Test stats 🧪

Test Results
Failed 0
Passed 6
Skipped 0
Total 6

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@kush-elastic kush-elastic added enhancement New feature or request Integration:php_fpm PHP-FPM Team:Service-Integrations Label for the Observability Service Integrations team labels Nov 9, 2022
@kush-elastic
Copy link
Contributor

/test

@kush-elastic
Copy link
Contributor

/test

@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

elasticmachine commented Nov 9, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚 2.314
Classes 100.0% (1/1) 💚 2.314
Methods 100.0% (8/8) 💚 8.73
Lines 95.763% (113/118) 👍 4.058
Conditionals 100.0% (0/0) 💚

@kush-elastic
Copy link
Contributor

LGTM

@@ -0,0 +1,18 @@
FROM bitnami/php-fpm:8.1.12-debian-11-r4
Copy link
Contributor

@ManojS-shetty ManojS-shetty Nov 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We never came across adding docker image in elastic repo till now. Also we do not have the access for the elastic repo.

@harnish-crest harnish-crest requested review from ManojS-shetty and removed request for lalit-satapathy November 21, 2022 09:20
Copy link
Contributor

@ManojS-shetty ManojS-shetty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kush-elastic kush-elastic merged commit 14fe5f2 into elastic:main Nov 24, 2022
@elasticmachine
Copy link

Package php_fpm - 0.1.0 containing this change is available at https://epr.elastic.co/search?package=php_fpm

@andrewkroh andrewkroh added the New Integration Issue or pull request for creating a new integration package. label Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:php_fpm PHP-FPM New Integration Issue or pull request for creating a new integration package. Team:Service-Integrations Label for the Observability Service Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants