Refactor EXLA NIFs to use Fine #1581
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
920f95b to
d7e7cfb
Compare
josevalim
reviewed
Feb 19, 2025
josevalim
reviewed
Feb 19, 2025
josevalim
approved these changes
Feb 19, 2025
Co-authored-by: José Valim <[email protected]>
jonatanklosko
commented
Feb 19, 2025
polvalente
reviewed
Feb 19, 2025
TomasPegado
pushed a commit
to TomasPegado/nx
that referenced
this pull request
Mar 31, 2025
Co-authored-by: José Valim <[email protected]>
TomasPegado
pushed a commit
to TomasPegado/nx
that referenced
this pull request
Apr 1, 2025
Co-authored-by: José Valim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on pythonx, I built a small C++ library to reduce the amount of boilerplate necessary for encoding/decoding terms between Elixir and C++, providing conveniences around resources, and more. I've just extracted it into elixir-nx/fine.
This PR rewrites EXLA NIFs. I used this to further validate Fine, and given the amount of removed code, I believe it makes for a good case. The most important features is encoding/decoding based on NIF signature, and managing resources.
Also, while rewriting the resource management, I noticed a few possible memory leaks, which should now be addressed.