Skip to content

Replaced #[path] with some #[cfg] attributes to avoid an ICE #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 14, 2018
Merged

Replaced #[path] with some #[cfg] attributes to avoid an ICE #214

merged 1 commit into from
Dec 14, 2018

Conversation

Michael-F-Bryan
Copy link
Contributor

In zmq-sys, the use of the #[path] attribute to make things more cross-platform causes an ICE when running cargo doc on nightly.

cc: rust-lang/rust#47391

@Michael-F-Bryan
Copy link
Contributor Author

It looks like travis is failing on nightly because the compiletest crate has changed. @erickt, would you like me to make a PR to upgrade the compile-test code as well?

@erickt erickt mentioned this pull request Dec 14, 2018
@erickt erickt merged commit c880c5a into erickt:master Dec 14, 2018
erickt added a commit that referenced this pull request Dec 14, 2018
@erickt
Copy link
Owner

erickt commented Dec 14, 2018

A belated thank you! I just merged this in.

@Michael-F-Bryan Michael-F-Bryan deleted the ice branch March 23, 2019 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants