Skip to content

feat(fcm): Add image in notification support. #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 27, 2019
Merged

feat(fcm): Add image in notification support. #298

merged 5 commits into from
Aug 27, 2019

Conversation

chong-shao
Copy link
Contributor

@chong-shao chong-shao commented Aug 5, 2019 •
edited by hiranya911
Loading

Add image in notification support.

Testing

  • Added unit tests and modified one existing integration test to reflect this change.

API Changes

  • In Firebase Cloud Messaging, added "image" field in the general Notification class, the AndroidNotification class, and the ApnsFcmOptions class.

RELEASE NOTE: Added new APIs for specifying an image URL in notifications.

@chong-shao chong-shao requested a review from hiranya911 August 14, 2019 23:06
@hiranya911 hiranya911 changed the title Add image in notification support. feat(fcm): Add image in notification support. Aug 20, 2019
hiranya911
hiranya911 suggested changes Aug 20, 2019
View reviewed changes
Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good. Just a few suggestions.

Do we need to validate the imageUrl argument? (check not not empty and parse as a valid URL)

@chong-shao
Copy link
Contributor Author

chong-shao commented Aug 27, 2019 •
edited
Loading

I think there's no need to validate the imageUrl argument since the HTTP API also does not do the check.

hiranya911
hiranya911 approved these changes Aug 27, 2019
View reviewed changes
Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@chong-shao chong-shao merged commit cfb1989 into master Aug 27, 2019
@chong-shao chong-shao deleted the image_in_notification branch August 27, 2019 23:42
@hiranya911 hiranya911 mentioned this pull request Sep 3, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiranya911 hiranya911 hiranya911 approved these changes

Assignees

@chong-shao chong-shao

Labels
release-note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chong-shao @hiranya911