Port app.get() check from errorprone to lint (#4434)

* Port app.get() check from errorprone to lint

Motivation: Make sure the check works for kotlin, not only java.

* Add copyrights

Author: vkryachko

buildSrc/src/main/java/com/google/firebase/gradle/plugins/FirebaseJavaLibraryPlugin.java

@@ -68,13 +68,6 @@ private static void setupStaticAnalysis(Project project, FirebaseLibraryExtensio
                 .getConfigurations()
                 .all(
                     c -> {
-                      if ("annotationProcessor".equals(c.getName())) {
-                        for (String checkProject : library.staticAnalysis.errorproneCheckProjects) {
-                          project
-                              .getDependencies()
-                              .add("annotationProcessor", project.project(checkProject));
-                        }
-                      }
                       if ("lintChecks".equals(c.getName())) {
                         for (String checkProject :
                             library.staticAnalysis.androidLintCheckProjects) {

buildSrc/src/main/java/com/google/firebase/gradle/plugins/FirebaseLibraryExtension.java

@@ -91,7 +91,6 @@ public FirebaseLibraryExtension(Project project, LibraryType type) {
 
   private FirebaseStaticAnalysis initializeStaticAnalysis(Project project) {
     return new FirebaseStaticAnalysis(
-        projectsFromProperty(project, "firebase.checks.errorproneProjects"),
         projectsFromProperty(project, "firebase.checks.lintProjects"));
   }
 

buildSrc/src/main/java/com/google/firebase/gradle/plugins/FirebaseLibraryPlugin.java

@@ -213,13 +213,6 @@ private static void setupStaticAnalysis(Project project, FirebaseLibraryExtensio
                 .getConfigurations()
                 .all(
                     c -> {
-                      if ("annotationProcessor".equals(c.getName())) {
-                        for (String checkProject : library.staticAnalysis.errorproneCheckProjects) {
-                          project
-                              .getDependencies()
-                              .add("annotationProcessor", project.project(checkProject));
-                        }
-                      }
                       if ("lintChecks".equals(c.getName())) {
                         for (String checkProject :
                             library.staticAnalysis.androidLintCheckProjects) {

buildSrc/src/main/java/com/google/firebase/gradle/plugins/FirebaseStaticAnalysis.java

@@ -17,12 +17,9 @@
 import java.util.Set;
 
 public class FirebaseStaticAnalysis {
-  public Set<String> errorproneCheckProjects;
   public Set<String> androidLintCheckProjects;
 
-  public FirebaseStaticAnalysis(
-      Set<String> errorproneCheckProjects, Set<String> androidLintCheckProjects) {
-    this.errorproneCheckProjects = errorproneCheckProjects;
+  public FirebaseStaticAnalysis(Set<String> androidLintCheckProjects) {
     this.androidLintCheckProjects = androidLintCheckProjects;
   }
 }

gradle.properties

@@ -16,7 +16,6 @@ org.gradle.jvmargs=-Xmx8g -XX:MaxPermSize=8g
 org.gradle.parallel=true
 org.gradle.caching=true
 
-firebase.checks.errorproneProjects=:tools:errorprone
 firebase.checks.lintProjects=:tools:lint
 
 systemProp.illegal-access=warn

subprojects.cfg

@@ -67,7 +67,6 @@ encoders:protoc-gen-firebase-encoders:tests
 
 integ-testing
 
-tools:errorprone
 tools:lint
 
 transport