Skip to content

Read version control info from Android resource #6754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 11, 2025
Merged

Read version control info from Android resource #6754

merged 3 commits into from
Mar 11, 2025

Conversation

mrober
Copy link
Contributor

@mrober mrober commented Mar 10, 2025

Read version control info from an Android string resource, then fall back to the old slower method.

The Crashlytics Gradle plugin will need to be updated to generate this string resource.

Copy link
Contributor

github-actions bot commented Mar 10, 2025

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 10, 2025

Coverage Report 1

Affected Products

  • firebase-crashlytics

    Overall coverage changed from 11.53% (dfd0d7c) to 11.53% (f5d22e5) by +0.00%.

    FilenameBase (dfd0d7c)Merge (f5d22e5)Diff
    CommonUtils.java1.09%1.06%-0.02%
    CrashlyticsController.java18.52%18.64%+0.12%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/rHnCc4sfw0.html

Copy link
Contributor

github-actions bot commented Mar 10, 2025

Test Results

 8 files   - 6   8 suites   - 6   19s ⏱️ +7s
22 tests  - 1  22 ✅  - 1  0 💤 ±0  0 ❌ ±0 
44 runs   - 2  44 ✅  - 2  0 💤 ±0  0 ❌ ±0 

Results for commit 3831b52. ± Comparison against base commit 7c03f49.

This pull request removes 23 and adds 22 tests. Note that renamed tests count towards both.
com.google.firebase.functions.AppCheckLimitedUseTest ‑ FirebaseFunctions#getHttpsCallable should build callable with FAC settings (when false)
com.google.firebase.functions.AppCheckLimitedUseTest ‑ FirebaseFunctions#getHttpsCallable should build callable with FAC settings (when true)
com.google.firebase.functions.AppCheckLimitedUseTest ‑ FirebaseFunctions#getHttpsCallable should not use limited-use tokens by default
com.google.firebase.functions.AppCheckLimitedUseTest ‑ FirebaseFunctions#getHttpsCallableFromUrl callable with FAC settings (when false)
com.google.firebase.functions.AppCheckLimitedUseTest ‑ FirebaseFunctions#getHttpsCallableFromUrl callable with FAC settings (when true)
com.google.firebase.functions.AppCheckLimitedUseTest ‑ FirebaseFunctions#getHttpsCallableFromUrl should not use limited-use tokens by default
com.google.firebase.functions.FunctionsRegistrarTest ‑ getComponents_publishesLibVersionComponent
com.google.firebase.functions.FunctionsTests ‑ Firebase#functions should delegate to FirebaseFunctions#getInstance(FirebaseApp, region)
com.google.firebase.functions.FunctionsTests ‑ Firebase#functions should delegate to FirebaseFunctions#getInstance(region)
com.google.firebase.functions.FunctionsTests ‑ FirebaseApp#functions should delegate to FirebaseFunctions#getInstance(FirebaseApp)
…
com.google.firebase.crashlytics.internal.common.CrashlyticsControllerRobolectricTest ‑ testDoCloseSession_disabledAnrs_doesNotPersistsAppExitInfo
com.google.firebase.crashlytics.internal.common.CrashlyticsControllerRobolectricTest ‑ testDoCloseSession_enabledAnrs_doesNotPersistsAppExitInfoIfItDoesntExist
com.google.firebase.crashlytics.internal.common.CrashlyticsControllerRobolectricTest ‑ testDoCloseSession_enabledAnrs_persistsAppExitInfoIfItExists
com.google.firebase.crashlytics.internal.common.DataCollectionArbiterRobolectricTest ‑ testDefaultDataCollection_usedWhenNoOverrideOrManifestSetting
com.google.firebase.crashlytics.internal.common.DataCollectionArbiterRobolectricTest ‑ testManifestMetadata_respectedWhenNoOverride
com.google.firebase.crashlytics.internal.common.DataCollectionArbiterRobolectricTest ‑ testSetCrashlyticsDataCollectionEnabled_overridesOtherSettings
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testAppExitInfoEvent_notPersistIfAnrBeforeSession
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testAppExitInfoEvent_notPersistIfAppExitInfoNotAnrButWithinSession
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testAppExitInfoEvent_persistIfAnrWithinSession
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testAppExitInfoEvent_persistIfAnrWithinSession_multipleAppExitInfo
…

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 10, 2025

Size Report 1

Affected Products

  • firebase-crashlytics

    TypeBase (dfd0d7c)Merge (f5d22e5)Diff
    aar415 kB415 kB+441 B (+0.1%)
    apk (aggressive)522 kB523 kB+296 B (+0.1%)
    apk (release)6.62 MB6.62 MB+388 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/NsTgs6wzJa.html

@mrober mrober requested a review from themiswang March 10, 2025 20:54
@mrober mrober enabled auto-merge (squash) March 10, 2025 20:56
@mrober mrober merged commit 68f52ed into main Mar 11, 2025
42 of 43 checks passed
@mrober mrober deleted the mrober/vcinfo branch March 11, 2025 13:16
@firebase firebase locked and limited conversation to collaborators Apr 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants