Skip to content

Revert "Handle bridge methods while mapping" #5704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

cherylEnkidu
Copy link
Contributor

This PR breaks some tests, need to be re-evaluated before merging in.

Copy link
Contributor

github-actions bot commented Feb 12, 2024

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-database

    Overall coverage changed from 50.19% (5125155) to 50.12% (dfda7ba) by -0.07%.

    FilenameBase (5125155)Merge (dfda7ba)Diff
    ChildChangeAccumulator.java83.33%96.67%+13.33%
    CustomClassMapper.java88.63%88.33%-0.30%
    DoubleNode.java100.00%88.24%-11.76%
    QueryParams.java89.76%90.36%+0.60%
    WebsocketConnection.java35.03%32.77%-2.26%
  • firebase-firestore

    Overall coverage changed from 44.85% (5125155) to 44.84% (dfda7ba) by -0.01%.

    FilenameBase (5125155)Merge (dfda7ba)Diff
    CustomClassMapper.java84.00%84.25%+0.25%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/IhNY5YzPlF.html

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • firebase-database

    TypeBase (5125155)Merge (dfda7ba)Diff
    aar537 kB537 kB-273 B (-0.1%)
    apk (release)5.40 MB5.39 MB-164 B (-0.0%)
  • firebase-firestore

    TypeBase (5125155)Merge (dfda7ba)Diff
    aar1.41 MB1.41 MB-212 B (-0.0%)
    apk (release)11.4 MB11.4 MB-156 B (-0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/zXdxOzlWXA.html

Copy link
Contributor

Unit Test Results

   250 files   -    318     250 suites   - 318   4m 59s ⏱️ - 14m 13s
1 640 tests  - 1 946  1 622 ✔️  - 1 948  18 💤 +2  0 ±0 
3 330 runs   - 3 902  3 294 ✔️  - 3 906  36 💤 +4  0 ±0 

Results for commit 4b6ab73. ± Comparison against base commit 5125155.

@google-oss-bot
Copy link
Contributor

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

Startup Times

  • fire-fst

    DeviceStatisticsDistributions
    oriole-32
    Percentile5125155dfda7baDiffSignificant (?)
    p10381 ±166 μs371 ±157 μs-9.97 μs (-2.6%)NO
    p25399 ±166 μs383 ±162 μs-16.0 μs (-4.0%)NO
    p50433 ±170 μs411 ±167 μs-21.8 μs (-5.0%)NO
    p75508 ±178 μs467 ±174 μs-41.2 μs (-8.1%)NO
    p90617 ±191 μs552 ±186 μs-65.2 μs (-10.6%)NO

    20 test runs in comparison
    CommitTest Runs
    5125155
    • 2024-02-09_23:21:09.581483_eOpM
    • 2024-02-09_23:21:09.581523_gHvd
    • 2024-02-09_23:21:09.581537_AKNo
    • 2024-02-09_23:21:09.581548_wMte
    • 2024-02-09_23:21:09.581557_ySwL
    • 2024-02-09_23:21:09.581562_ZljA
    • 2024-02-09_23:21:09.581566_yPVK
    • 2024-02-09_23:21:09.581570_WdNr
    • 2024-02-09_23:21:09.581575_xGWd
    • 2024-02-09_23:21:09.581579_gxOk
    dfda7ba
    • 2024-02-12_15:21:44.665939_nSJP
    • 2024-02-12_15:21:44.665973_MkQa
    • 2024-02-12_15:21:44.665984_oKPT
    • 2024-02-12_15:21:44.665993_IXFt
    • 2024-02-12_15:21:44.666009_oaon
    • 2024-02-12_15:21:44.666015_yfLo
    • 2024-02-12_15:21:44.666019_pkJM
    • 2024-02-12_15:21:44.666023_SziY
    • 2024-02-12_15:21:44.666027_DulZ
    • 2024-02-12_15:21:44.666031_tGmN
    redfin-30
    Percentile5125155dfda7baDiffSignificant (?)
    p10606 ±27 μs621 ±58 μs+15.3 μs (+2.5%)NO
    p25626 ±28 μs643 ±67 μs+17.2 μs (+2.7%)NO
    p50660 ±38 μs673 ±73 μs+13.8 μs (+2.1%)NO
    p75699 ±47 μs722 ±96 μs+22.6 μs (+3.2%)NO
    p90762 ±77 μs798 ±148 μs+35.6 μs (+4.7%)NO

    20 test runs in comparison
    CommitTest Runs
    5125155
    • 2024-02-09_23:21:09.581483_eOpM
    • 2024-02-09_23:21:09.581523_gHvd
    • 2024-02-09_23:21:09.581537_AKNo
    • 2024-02-09_23:21:09.581548_wMte
    • 2024-02-09_23:21:09.581557_ySwL
    • 2024-02-09_23:21:09.581562_ZljA
    • 2024-02-09_23:21:09.581566_yPVK
    • 2024-02-09_23:21:09.581570_WdNr
    • 2024-02-09_23:21:09.581575_xGWd
    • 2024-02-09_23:21:09.581579_gxOk
    dfda7ba
    • 2024-02-12_15:21:44.665939_nSJP
    • 2024-02-12_15:21:44.665973_MkQa
    • 2024-02-12_15:21:44.665984_oKPT
    • 2024-02-12_15:21:44.665993_IXFt
    • 2024-02-12_15:21:44.666009_oaon
    • 2024-02-12_15:21:44.666015_yfLo
    • 2024-02-12_15:21:44.666019_pkJM
    • 2024-02-12_15:21:44.666023_SziY
    • 2024-02-12_15:21:44.666027_DulZ
    • 2024-02-12_15:21:44.666031_tGmN
  • fire-rtdb

    DeviceStatisticsDistributions
    oriole-32
    Percentile5125155dfda7baDiffSignificant (?)
    p1033.4 ±6 μs35.2 ±6 μs+1.79 μs (+5.3%)NO
    p2536.6 ±8 μs38.3 ±6 μs+1.77 μs (+4.8%)NO
    p5042.8 ±11 μs43.5 ±7 μs+665 ns (+1.6%)NO
    p7554.9 ±15 μs54.8 ±12 μs-165 ns (-0.3%)NO
    p9076.4 ±27 μs81.0 ±34 μs+4.62 μs (+6.0%)NO

    20 test runs in comparison
    CommitTest Runs
    5125155
    • 2024-02-09_23:21:09.581483_eOpM
    • 2024-02-09_23:21:09.581523_gHvd
    • 2024-02-09_23:21:09.581537_AKNo
    • 2024-02-09_23:21:09.581548_wMte
    • 2024-02-09_23:21:09.581557_ySwL
    • 2024-02-09_23:21:09.581562_ZljA
    • 2024-02-09_23:21:09.581566_yPVK
    • 2024-02-09_23:21:09.581570_WdNr
    • 2024-02-09_23:21:09.581575_xGWd
    • 2024-02-09_23:21:09.581579_gxOk
    dfda7ba
    • 2024-02-12_15:21:44.665939_nSJP
    • 2024-02-12_15:21:44.665973_MkQa
    • 2024-02-12_15:21:44.665984_oKPT
    • 2024-02-12_15:21:44.665993_IXFt
    • 2024-02-12_15:21:44.666009_oaon
    • 2024-02-12_15:21:44.666015_yfLo
    • 2024-02-12_15:21:44.666019_pkJM
    • 2024-02-12_15:21:44.666023_SziY
    • 2024-02-12_15:21:44.666027_DulZ
    • 2024-02-12_15:21:44.666031_tGmN
    redfin-30
    Percentile5125155dfda7baDiffSignificant (?)
    p1068.8 ±9 μs133 ±166 μs+64.3 μs (+93.5%)NO
    p2574.5 ±9 μs138 ±169 μs+63.2 μs (+84.8%)NO
    p5083.8 ±13 μs144 ±171 μs+60.3 μs (+71.9%)NO
    p7593.8 ±17 μs157 ±173 μs+63.3 μs (+67.5%)NO
    p90115 ±29 μs175 ±176 μs+60.1 μs (+52.4%)NO

    20 test runs in comparison
    CommitTest Runs
    5125155
    • 2024-02-09_23:21:09.581483_eOpM
    • 2024-02-09_23:21:09.581523_gHvd
    • 2024-02-09_23:21:09.581537_AKNo
    • 2024-02-09_23:21:09.581548_wMte
    • 2024-02-09_23:21:09.581557_ySwL
    • 2024-02-09_23:21:09.581562_ZljA
    • 2024-02-09_23:21:09.581566_yPVK
    • 2024-02-09_23:21:09.581570_WdNr
    • 2024-02-09_23:21:09.581575_xGWd
    • 2024-02-09_23:21:09.581579_gxOk
    dfda7ba
    • 2024-02-12_15:21:44.665939_nSJP
    • 2024-02-12_15:21:44.665973_MkQa
    • 2024-02-12_15:21:44.665984_oKPT
    • 2024-02-12_15:21:44.665993_IXFt
    • 2024-02-12_15:21:44.666009_oaon
    • 2024-02-12_15:21:44.666015_yfLo
    • 2024-02-12_15:21:44.666019_pkJM
    • 2024-02-12_15:21:44.666023_SziY
    • 2024-02-12_15:21:44.666027_DulZ
    • 2024-02-12_15:21:44.666031_tGmN
  • timeToInitialDisplay

    DeviceStatisticsDistributions
    oriole-32
    Percentile5125155dfda7baDiffSignificant (?)
    p10205 ±6 ms207 ±1 ms+1.99 ms (+1.0%)NO
    p25211 ±8 ms213 ±2 ms+1.64 ms (+0.8%)NO
    p50219 ±9.8 ms221 ±3 ms+1.76 ms (+0.8%)NO
    p75231 ±24 ms231 ±4 ms-558 μs (-0.2%)NO
    p90241 ±28 ms245 ±8 ms+4.05 ms (+1.7%)NO

    20 test runs in comparison
    CommitTest Runs
    5125155
    • 2024-02-09_23:21:09.581483_eOpM
    • 2024-02-09_23:21:09.581523_gHvd
    • 2024-02-09_23:21:09.581537_AKNo
    • 2024-02-09_23:21:09.581548_wMte
    • 2024-02-09_23:21:09.581557_ySwL
    • 2024-02-09_23:21:09.581562_ZljA
    • 2024-02-09_23:21:09.581566_yPVK
    • 2024-02-09_23:21:09.581570_WdNr
    • 2024-02-09_23:21:09.581575_xGWd
    • 2024-02-09_23:21:09.581579_gxOk
    dfda7ba
    • 2024-02-12_15:21:44.665939_nSJP
    • 2024-02-12_15:21:44.665973_MkQa
    • 2024-02-12_15:21:44.665984_oKPT
    • 2024-02-12_15:21:44.665993_IXFt
    • 2024-02-12_15:21:44.666009_oaon
    • 2024-02-12_15:21:44.666015_yfLo
    • 2024-02-12_15:21:44.666019_pkJM
    • 2024-02-12_15:21:44.666023_SziY
    • 2024-02-12_15:21:44.666027_DulZ
    • 2024-02-12_15:21:44.666031_tGmN
    redfin-30
    Percentile5125155dfda7baDiffSignificant (?)
    p10248 ±5 ms277 ±13 ms+29.3 ms (+11.8%)NO
    p25255 ±4 ms285 ±15 ms+29.8 ms (+11.7%)NO
    p50263 ±5 ms293 ±18 ms+30.1 ms (+11.5%)NO
    p75273 ±6 ms304 ±17 ms+31.4 ms (+11.5%)NO
    p90283 ±7 ms322 ±17 ms+39.0 ms (+13.8%)NO

    20 test runs in comparison
    CommitTest Runs
    5125155
    • 2024-02-09_23:21:09.581483_eOpM
    • 2024-02-09_23:21:09.581523_gHvd
    • 2024-02-09_23:21:09.581537_AKNo
    • 2024-02-09_23:21:09.581548_wMte
    • 2024-02-09_23:21:09.581557_ySwL
    • 2024-02-09_23:21:09.581562_ZljA
    • 2024-02-09_23:21:09.581566_yPVK
    • 2024-02-09_23:21:09.581570_WdNr
    • 2024-02-09_23:21:09.581575_xGWd
    • 2024-02-09_23:21:09.581579_gxOk
    dfda7ba
    • 2024-02-12_15:21:44.665939_nSJP
    • 2024-02-12_15:21:44.665973_MkQa
    • 2024-02-12_15:21:44.665984_oKPT
    • 2024-02-12_15:21:44.665993_IXFt
    • 2024-02-12_15:21:44.666009_oaon
    • 2024-02-12_15:21:44.666015_yfLo
    • 2024-02-12_15:21:44.666019_pkJM
    • 2024-02-12_15:21:44.666023_SziY
    • 2024-02-12_15:21:44.666027_DulZ
    • 2024-02-12_15:21:44.666031_tGmN

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/ApidXVxiIQ/index.html

@cherylEnkidu cherylEnkidu merged commit a4ca0cb into master Feb 12, 2024
@cherylEnkidu cherylEnkidu deleted the revert-5626-exclude-bridge-methods-from-mapping branch February 12, 2024 16:47
cherylEnkidu added a commit that referenced this pull request Feb 12, 2024
cherylEnkidu added a commit that referenced this pull request Feb 12, 2024
jadenlin-g pushed a commit that referenced this pull request Feb 15, 2024
This PR breaks some tests, need to be re-evaluated before merging in.
cherylEnkidu added a commit that referenced this pull request Feb 16, 2024
@firebase firebase locked and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants