Skip to content

Commit 7639a73

Browse files
committed
update firestore_test file
1 parent 158986f commit 7639a73

File tree

3 files changed

+7
-8
lines changed

3 files changed

+7
-8
lines changed

firestore/integration_test_internal/src/firestore_test.cc

+2-2
Original file line numberDiff line numberDiff line change
@@ -67,8 +67,8 @@ using ::testing::HasSubstr;
6767

6868
class FirestoreTest : public FirestoreIntegrationTest {
6969
protected:
70-
const std::string GetFirestoreDatabaseId(Firestore* firestore) {
71-
return GetInternal(firestore)->database_name();
70+
const std::string& GetFirestoreDatabaseId(Firestore* firestore) {
71+
return GetInternal(firestore)->database_id().database_id();
7272
}
7373
};
7474

firestore/src/android/firestore_android.h

+1-3
Original file line numberDiff line numberDiff line change
@@ -166,9 +166,7 @@ class FirestoreInternal {
166166
firestore_public_ = firestore_public;
167167
}
168168

169-
const model::DatabaseId& database_id() const {
170-
return this->database_id();
171-
}
169+
const model::DatabaseId& database_id() const { return this->database_id(); }
172170

173171
Firestore* firestore_public() { return firestore_public_; }
174172
const Firestore* firestore_public() const { return firestore_public_; }

firestore/src/common/firestore.cc

+4-3
Original file line numberDiff line numberDiff line change
@@ -199,8 +199,8 @@ Firestore* Firestore::AddFirestoreToCache(Firestore* firestore,
199199
return nullptr;
200200
}
201201

202-
FirestoreMap::key_type key =
203-
MakeKey(firestore->app(), firestore->internal_->database_id().database_id());
202+
FirestoreMap::key_type key = MakeKey(
203+
firestore->app(), firestore->internal_->database_id().database_id());
204204
FirestoreCache()->emplace(key, firestore);
205205
return firestore;
206206
}
@@ -381,7 +381,8 @@ Future<void> Firestore::EnableNetwork() {
381381

382382
Future<void> Firestore::Terminate() {
383383
if (!internal_) return FailedFuture<void>();
384-
FirestoreMap::key_type key = MakeKey(app(), internal_->database_id().database_id());
384+
FirestoreMap::key_type key =
385+
MakeKey(app(), internal_->database_id().database_id());
385386

386387
FirestoreCache()->erase(key);
387388
return internal_->Terminate();

0 commit comments

Comments
 (0)