Skip to content

Modify deprecation notice. #1616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 25, 2024
Merged

Modify deprecation notice. #1616

merged 2 commits into from
Jun 25, 2024

Conversation

jonsimantov
Copy link
Contributor

Description

Provide details of the change, and generalize the change in the PR title above.


Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@jonsimantov jonsimantov requested a review from a-maurice June 25, 2024 19:54
@jonsimantov jonsimantov added the skip-release-notes Skip release notes check label Jun 25, 2024
@@ -55,15 +55,32 @@ template <typename ResultType>
class Future {
// Empty class (used for documentation only).
};

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is needed because the newly created GMA deprecation page throws a docs warning since it can't find firebase::App docs.

@jonsimantov jonsimantov merged commit d170cb6 into main Jun 25, 2024
34 of 47 checks passed
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Jun 25, 2024
Copy link

github-actions bot commented Jun 25, 2024

✅  Integration test succeeded!

Requested by @jonsimantov on commit d170cb6
Last updated: Tue Jun 25 14:09 PDT 2024
View integration test log & download artifacts

@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Jun 25, 2024
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jun 25, 2024
@firebase firebase locked and limited conversation to collaborators Jul 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
skip-release-notes Skip release notes check tests: succeeded This PR's integration tests succeeded.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants