Skip to content

Fix #973 Make sure all resources are closed in RegistrationIntentService #998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 17, 2022
Merged

Fix #973 Make sure all resources are closed in RegistrationIntentService #998

merged 4 commits into from
Jun 17, 2022

Conversation

chkuang-g
Copy link
Contributor

@chkuang-g chkuang-g commented Jun 17, 2022 •
edited
Loading

Make sure all FileStream and FileLock are closed using AutoClose pattern.

Description

Provide details of the change, and generalize the change in the PR title above.

Make sure all the resource are closed RegistrationIntentService using AutoClose and try-with-resources statement.

Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Using integration test workflow (pending)

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@chkuang-g
Fix #973 Make sure all resources are closed
2777b4c 
Make sure all FileStream and FileLock are closed using AutoClose pattern.
@chkuang-g chkuang-g added the tests-requested: quick Trigger a quick set of integration tests. label Jun 17, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Jun 17, 2022
@github-actions
Copy link

github-actions bot commented Jun 17, 2022 •
edited
Loading

✅  Integration test succeeded!

Requested by @chkuang-g on commit a2279e9
Last updated: Fri Jun 17 14:09 PDT 2022
View integration test log & download artifacts

chkuang-g added 2 commits June 16, 2022 18:39
@chkuang-g
Fix #973 Make sure all resources are closed
d8abadc 
Make sure all FileStream and FileLock are closed using AutoClose pattern.
@chkuang-g
Fix #973 Make sure all resources are closed
05f20ca 
Make sure all FileStream and FileLock are closed using AutoClose pattern.
@chkuang-g chkuang-g added the tests-requested: quick Trigger a quick set of integration tests. label Jun 17, 2022
@github-actions github-actions bot added tests: succeeded This PR's integration tests succeeded. and removed tests-requested: quick Trigger a quick set of integration tests. labels Jun 17, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jun 17, 2022
@chkuang-g
Fix #973 Make sure all resources are closed
a2718bb 
Make sure all FileStream and FileLock are closed using AutoClose pattern.
@chkuang-g chkuang-g changed the title Fix #973 Make sure all resources are closed Fix #973 Make sure all resources are closed in RegistrationIntentService Jun 17, 2022
@chkuang-g chkuang-g merged commit a2279e9 into main Jun 17, 2022
@chkuang-g chkuang-g deleted the patch/fcm-closable branch June 17, 2022 18:28
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: succeeded This PR's integration tests succeeded. and removed tests: succeeded This PR's integration tests succeeded. labels Jun 17, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jun 17, 2022
@firebase firebase locked and limited conversation to collaborators Jul 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cynthiajoan cynthiajoan cynthiajoan approved these changes

@a-maurice a-maurice a-maurice approved these changes

@jonsimantov jonsimantov Awaiting requested review from jonsimantov

Assignees
No one assigned
Labels
tests: succeeded This PR's integration tests succeeded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chkuang-g @cynthiajoan @a-maurice